Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

feat(*): Add hpa to osm controller and injector #3499

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

shalier
Copy link
Contributor

@shalier shalier commented Jun 3, 2021

Description:
Adds horizontal pod autoscaler for osm-controller and osm-injector

Refer to the HA doc for more reference.
Part of #3390

Affected area:

Functional Area
New Functionality [ X ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [ ]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?
    no

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2021

Codecov Report

Merging #3499 (14c1ddd) into main (63c2fd2) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3499      +/-   ##
==========================================
+ Coverage   65.99%   66.01%   +0.02%     
==========================================
  Files         169      169              
  Lines        7895     7895              
==========================================
+ Hits         5210     5212       +2     
+ Misses       2654     2652       -2     
  Partials       31       31              
Flag Coverage Δ
unittests 66.01% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/kubernetes/announcement_handlers.go 77.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63c2fd2...14c1ddd. Read the comment docs.

@shalier shalier force-pushed the replicasHA branch 2 times, most recently from 14c1ddd to 23a5fd5 Compare June 3, 2021 18:22
@shalier shalier requested a review from shashankram June 3, 2021 18:24
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@shalier shalier marked this pull request as ready for review June 8, 2021 15:19
@shalier shalier requested a review from a team as a code owner June 8, 2021 15:19
@shalier
Copy link
Contributor Author

shalier commented Jun 8, 2021

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2021

Command refresh: success

Pull request refreshed

@shalier shalier merged commit 3f79415 into openservicemesh:main Jun 8, 2021
shashankram pushed a commit to shashankram/osm that referenced this pull request Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants