Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Log k8s version in CI #4047

Closed
ksubrmnn opened this issue Aug 26, 2021 · 3 comments · Fixed by #4049
Closed

Log k8s version in CI #4047

ksubrmnn opened this issue Aug 26, 2021 · 3 comments · Fixed by #4049
Assignees

Comments

@ksubrmnn
Copy link
Contributor

Please describe the Improvement and/or Feature Request

Log kubernetes version used in CI tests
Scope (please mark with X where applicable)

  • New Functionality [ ]
  • Install [ ]
  • SMI Traffic Access Policy [ ]
  • SMI Traffic Specs Policy [ ]
  • SMI Traffic Split Policy [ ]
  • Permissive Traffic Policy [ ]
  • Ingress [ ]
  • Egress [ ]
  • Envoy Control Plane [ ]
  • CLI Tool [ ]
  • Metrics [ ]
  • Certificate Management [ ]
  • Sidecar Injection [ ]
  • Logging [ ]
  • Debugging [ ]
  • Tests []
  • CI System [X]
  • Demo [ ]
  • Project Release [ ]

Possible use cases

@shashankram
Copy link
Member

This gets logged in the mandatory job Test various Envoy + SMI configuration scenarios. The node version below corresponds to the k8s version. By default, we do not specify a k8s version to test against so that the CI automatically picks up the latest k8s version to test against whenever available. This allows us to discover issues sooner when a new version introduces incompatible changes.

Creating cluster "osm" ...
 • Ensuring node image (kindest/node:v1.21.1) 🖼  ...
 ✓ Ensuring node image (kindest/node:v1.21.1) 🖼
 • Preparing nodes 📦 📦 📦   ...
 ✓ Preparing nodes 📦 📦 📦 

e2e tests use the same node, except in scenarios where the e2e test itself overrides the version such as in the e2e_k8s_version_test.go, in which case it's explicit enough:

[Tier 2][Bucket 6] Test HTTP traffic for different k8s versions Version v1.19.7 

Given that enough information is available to determine the version of k8s being used, both by default and when the test overrides the k8s version, I am closing this issue.

@ksubrmnn
Copy link
Contributor Author

@shashankram wouldn't there be value in adding it per e2e?

@shashankram
Copy link
Member

@shashankram wouldn't there be value in adding it per e2e?

e2e by default picks up the latest image (which is the same as the image already logged in the CI). We could explicitly log the version as well. This should be rather simple, so let me take this up.

@shashankram shashankram reopened this Aug 26, 2021
@shashankram shashankram self-assigned this Aug 26, 2021
shashankram added a commit to shashankram/osm that referenced this issue Aug 26, 2021
Logs k8s server version.
Resolves openservicemesh#4047

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit to shashankram/osm that referenced this issue Aug 26, 2021
Logs k8s server version.
Resolves openservicemesh#4047

Signed-off-by: Shashank Ram <[email protected]>
shashankram added a commit that referenced this issue Aug 26, 2021
Logs k8s server version.
Resolves #4047

Signed-off-by: Shashank Ram <[email protected]>
mergify bot pushed a commit that referenced this issue Sep 7, 2021
Logs k8s server version.
Resolves #4047

Signed-off-by: Shashank Ram <[email protected]>
(cherry picked from commit 7e39688)
mergify bot pushed a commit that referenced this issue Sep 7, 2021
Logs k8s server version.
Resolves #4047

Signed-off-by: Shashank Ram <[email protected]>
(cherry picked from commit 7e39688)
ksubrmnn pushed a commit that referenced this issue Sep 7, 2021
Logs k8s server version.
Resolves #4047

Signed-off-by: Shashank Ram <[email protected]>
(cherry picked from commit 7e39688)

Co-authored-by: Shashank Ram <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants