Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Avg and Max Envoy Update Time metrics are incorrect #3987

Closed
shalier opened this issue Aug 16, 2021 · 2 comments · Fixed by #4354
Closed

Avg and Max Envoy Update Time metrics are incorrect #3987

shalier opened this issue Aug 16, 2021 · 2 comments · Fixed by #4354
Assignees
@shalier
Labels
kind/bug Something isn't working
Milestone
vNext

Comments

@shalier
Copy link
Contributor

shalier commented Aug 16, 2021

Bug description:
@eduser25 found that avg and max are showing 300/600s for update time, but the histogram doesn't show any update more than 0.1s
MicrosoftTeams-image (1)
MicrosoftTeams-image (2)

Affected area (please mark with X where applicable):

  • Install [ ]
  • SMI Traffic Access Policy [ ]
  • SMI Traffic Specs Policy [ ]
  • SMI Traffic Split Policy [ ]
  • Permissive Traffic Policy [ ]
  • Ingress [ ]
  • Egress [ ]
  • Envoy Control Plane [ ]
  • CLI Tool [ ]
  • Metrics [ x]
  • Certificate Management [ ]
  • Sidecar Injection [ ]
  • Logging [ ]
  • Debugging [ ]
  • Tests [ ]
  • Demo [ ]
  • CI System [ ]
@shalier shalier added the kind/bug Something isn't working label Aug 16, 2021
@shalier shalier self-assigned this Aug 16, 2021
@shalier
Copy link
Contributor Author

shalier commented Aug 17, 2021

Max update time can't be calculated using Prometheus
https://groups.google.com/g/prometheus-users/c/4V3A0t6u9ME

@phillipgibson phillipgibson added this to the v0.10.0 milestone Aug 18, 2021
@draychev draychev modified the milestones: v0.10.0, vNext Aug 19, 2021
@michelleN
Copy link
Contributor

@shalier Thanks for pointing this out. How is update time being calculated today?

shalier added a commit to shalier/osm that referenced this issue Nov 11, 2021
@shalier
Remove avg and max envoy update time metrics from grafana dashboard
8e72beb 
and resolves openservicemesh#3987

Signed-off-by: Shalier Xia <[email protected]>
@shalier shalier mentioned this issue Nov 11, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shalier shalier

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
vNext
4 participants
@michelleN @phillipgibson @draychev @shalier