Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Create a osm config for osm binary cli params #3978

Closed
phillipgibson opened this issue Aug 13, 2021 · 0 comments
Closed

Create a osm config for osm binary cli params #3978

phillipgibson opened this issue Aug 13, 2021 · 0 comments
Assignees
@shashankram
Milestone
v0.10.0

Comments

@phillipgibson
Copy link
Contributor

phillipgibson commented Aug 13, 2021 •
edited by shashankram
Loading

Please describe the Improvement and/or Feature Request
Since OSM will be integrated with hosted/managed K8 deployments, a configuration could be created on what target namespace OSM is installed in for osm binary commands.

Scope (please mark with X where applicable)

  • New Functionality [X]

Possible use cases
User can set context for the binary to use certain parameters. If the user is using the OSM AKS add-on, which deploys OSM in the kube-system namespace, the user can update the osm binary config to say the default namespace is "kube-system". This will prevent users having to continuously be aware of and append -n kube-system when not running upstream OSM.
@shashankram shashankram self-assigned this Aug 20, 2021
@shashankram shashankram added this to the v0.10.0 milestone Aug 20, 2021
shashankram added a commit to shashankram/osm that referenced this issue Aug 20, 2021
@shashankram
cli: provide environment override capability
9c2b5b6 
Provides the capability to override default namespace
and commands in osm cli. This is required to provide
a better experience of osm cli in managed environments.

It works as follows:
1. If osm config file is present, either in $HOME/.osm/config
   or specified via the OSM_CONFIG env var, this file will be
   used for environment defaults. This works similar to
   KUBECONFIG where the env variable overrides the static
   file if present.
2. If osm config file is not present, defaults values are
   used for the environment configurations.
3. If the install kind is set to `managed` in the config file,
   then install/uninstall/upgrade/dashboard commands which
   are only meant for self-hosted environments are disabled.

Resolves openservicemesh#3978

Signed-off-by: Shashank Ram <[email protected]>
@shashankram shashankram mentioned this issue Aug 20, 2021
Merged
shashankram added a commit to shashankram/osm that referenced this issue Aug 20, 2021
@shashankram
cli: provide environment override capability
10d1704 
Provides the capability to override default namespace
and commands in osm cli. This is required to provide
a better experience of osm cli in managed environments.

It works as follows:
1. If osm config file is present, either in $HOME/.osm/config
   or specified via the OSM_CONFIG env var, this file will be
   used for environment defaults. This works similar to
   KUBECONFIG where the env variable overrides the static
   file if present.
2. If osm config file is not present, defaults values are
   used for the environment configurations.
3. If the install kind is set to `managed` in the config file,
   then install/uninstall/upgrade/dashboard commands which
   are only meant for self-hosted environments are disabled.

Resolves openservicemesh#3978

Signed-off-by: Shashank Ram <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shashankram shashankram

Labels
None yet
Projects
None yet
Milestone
v0.10.0
Development

No branches or pull requests
2 participants
@phillipgibson @shashankram