Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Change preset-mesh-config to be a configmap rather than custom resource #3654

Closed
snehachhabria opened this issue Jun 23, 2021 · 0 comments · Fixed by #3662
Closed

Change preset-mesh-config to be a configmap rather than custom resource #3654

snehachhabria opened this issue Jun 23, 2021 · 0 comments · Fixed by #3662
Assignees
@snehachhabria
Labels
area/upgrade Upgrade related
Milestone
v0.10.0

Comments

@snehachhabria
Copy link
Contributor

snehachhabria commented Jun 23, 2021 •
edited
Loading

Please describe the Improvement and/or Feature Request

Update the preset-mesh-config (https://github.com/openservicemesh/osm/blob/main/charts/osm/templates/preset-mesh-config.yaml) from Kind: MeshConfig to Kind: ConfigMap

This is a pre-requisite for #3396, so that OSM can handle the life-cycle of CRD's. For smooth upgrades of CRD's and preventing helm validation to fail we will need to ensue that the helm chart in OSM don't create CR's.

Scope (please mark with X where applicable)

  • New Functionality [ ]
  • Install [ ]
  • SMI Traffic Access Policy [ ]
  • SMI Traffic Specs Policy [ ]
  • SMI Traffic Split Policy [ ]
  • Permissive Traffic Policy [ ]
  • Ingress [ ]
  • Egress [ ]
  • Envoy Control Plane [ ]
  • CLI Tool [ ]
  • Metrics [ ]
  • Certificate Management [ ]
  • Sidecar Injection [ ]
  • Logging [ ]
  • Debugging [ ]
  • Tests [ ]
  • CI System [ ]
  • Demo [ ]
  • Project Release [ ]
@snehachhabria snehachhabria self-assigned this Jun 23, 2021
@snehachhabria snehachhabria added the area/upgrade Upgrade related label Jun 23, 2021
@snehachhabria snehachhabria added this to the v0.10.0 milestone Jun 23, 2021
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 25, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
02412a8 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Signed-off-by: Sneha Chhabria <[email protected]>
@snehachhabria snehachhabria mentioned this issue Jun 25, 2021
Merged
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 25, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
94660cb 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 25, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
d52e7fc 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 25, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
4ed527c 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 25, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
2429d81 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Signed-off-by: Sneha Chhabria <[email protected]>
shalier pushed a commit to shalier/osm that referenced this issue Jun 30, 2021
@snehachhabria @shalier
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
77653cd 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Signed-off-by: Sneha Chhabria <[email protected]>
brunoterkaly pushed a commit to brunoterkaly/osm that referenced this issue Jul 3, 2021
@snehachhabria @brunoterkaly
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
85e66b4 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Signed-off-by: Sneha Chhabria <[email protected]>
mergify bot pushed a commit that referenced this issue Jul 8, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
f12b8f7 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes #3654

Signed-off-by: Sneha Chhabria <[email protected]>
(cherry picked from commit 2429d81)

# Conflicts:
#	charts/osm/templates/preset-mesh-config.yaml
#	cmd/init-osm-controller/init-osm-controller_test.go
snehachhabria added a commit that referenced this issue Jul 8, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
4a2b701 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes #3654

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 8, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
aba39c7 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Signed-off-by: Sneha Chhabria <[email protected]>
(cherry picked from commit 2429d81)
snehachhabria added a commit to snehachhabria/osm that referenced this issue Aug 13, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
8222027 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Backporting change openservicemesh@2429d81

Signed-off-by: Sneha Chhabria <[email protected]>
@snehachhabria snehachhabria mentioned this issue Aug 13, 2021
Merged
snehachhabria added a commit to snehachhabria/osm that referenced this issue Aug 13, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
12441b2 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Backporting change openservicemesh@2429d81

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Aug 13, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
13af402 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Backporting change openservicemesh@2429d81

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Aug 13, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
3b88364 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Backporting change openservicemesh@2429d81

Signed-off-by: Sneha Chhabria <[email protected]>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Aug 13, 2021
@snehachhabria
ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap
bc0c3cf 
This commit changes the kind of preset-mesh-config from MeshConfig to
ConfigMap

Fixes openservicemesh#3654

Backporting change openservicemesh@2429d81

Signed-off-by: Sneha Chhabria <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@snehachhabria snehachhabria

Labels
area/upgrade Upgrade related
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

ref(preset-mesh-config): Change kind of preset-mesh-config to ConfigMap snehachhabria/osm
1 participant
@snehachhabria