feat(log): add access log to TCP listener (#4625)

Add Envoy access log configuration to inbound & outbound listener for TCP traffic. Signed-off-by: Allen Leigh <[email protected]>
openservicemesh · Mar 31, 2022 · bd7e61d · bd7e61d
1 parent d1100a8
commit bd7e61d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/pkg/envoy/lds/listener.go b/pkg/envoy/lds/listener.go
@@ -42,6 +42,7 @@ func (lb *listenerBuilder) newOutboundListener() (*xds_listener.Listener, error)
 				Name: wellknown.OriginalDestination,
 			},
 		},
+		AccessLog: envoy.GetAccessLog(),
 	}
 
 	// Create a default passthrough filter chain when global egress is enabled.
@@ -122,6 +123,7 @@ func newInboundListener() *xds_listener.Listener {
 				Name: wellknown.OriginalDestination,
 			},
 		},
+		AccessLog: envoy.GetAccessLog(),
 	}
 }
 

diff --git a/pkg/envoy/lds/listener_test.go b/pkg/envoy/lds/listener_test.go
@@ -43,6 +43,7 @@ var _ = Describe("Construct inbound listeners", func() {
 		It("Tests the inbound listener config", func() {
 			listener := newInboundListener()
 			Expect(listener.Address).To(Equal(envoy.GetAddress(constants.WildcardIPAddr, constants.EnvoyInboundListenerPort)))
+			Expect(listener.AccessLog).NotTo(BeEmpty())
 			Expect(len(listener.ListenerFilters)).To(Equal(2)) // TlsInspector, OriginalDestination listener filter
 			Expect(listener.ListenerFilters[0].Name).To(Equal(wellknown.TlsInspector))
 			Expect(listener.TrafficDirection).To(Equal(xds_core.TrafficDirection_INBOUND))
@@ -202,6 +203,7 @@ func TestNewOutboundListener(t *testing.T) {
 	assert.NoError(err)
 
 	assert.Len(listener.ListenerFilters, 3) // OriginalDst, TlsInspector, HttpInspector
+	assert.NotEmpty(listener.AccessLog)
 	assert.Equal(wellknown.TlsInspector, listener.ListenerFilters[1].Name)
 	assert.Equal(&xds_listener.ListenerFilterChainMatchPredicate{
 		Rule: &xds_listener.ListenerFilterChainMatchPredicate_DestinationPortRange{