Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Commit

Permalink
codeowners: add @jaellio as an approver (#4423)
Browse files Browse the repository at this point in the history
I am nominating @jaellio to be an approver
for the osm repo as they have demonstrated
a good understanding of various areas of the
project while having contributed to core areas
such as observability, logging, tests, docs,
and releases.

**Maintainers**, if you agree with this nomination,
leave a "+1" comment and approve the the PR.

Signed-off-by: Shashank Ram <[email protected]>
  • Loading branch information
shashankram authored Jan 11, 2022
1 parent 5e29c53 commit 09af567
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# ref: https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

* @shashankram @snehachhabria @nojnhuh @draychev
* @shashankram @snehachhabria @nojnhuh @draychev @jaellio

# Emeritus maintainers
# @michelleN @eduser25
2 changes: 1 addition & 1 deletion CONTRIBUTOR_LADDER.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ A Maintainer must meet the rights, responsiblities, and requirements of a Contri

Process of becoming a maintainer:

1. Any current Maintainer may nominate a current Contributor to become a new Maintainer, by opening a PR against the root of the [OSM repository](https://github.com/openservicemesh/osm) adding the nominee to the [OWNERS file](https://github.com/openservicemesh/osm/blob/main/OWNERS).
1. Any current Maintainer may nominate a current Contributor to become a new Maintainer, by opening a PR against the root of the [OSM repository](https://github.com/openservicemesh/osm) adding the nominee to the [CODEOWNERS file](https://github.com/openservicemesh/osm/blob/main/CODEOWNERS).
2. The nominee will add a comment to the PR testifying that they agree to all requirements of becoming a Maintainer.
3. A majority of the current Maintainers must then approve the PR.

Expand Down

0 comments on commit 09af567

Please sign in to comment.