-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial implementation of OpenSergo Java client #1
Conversation
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
An example of how data-plane integrates with OpenSergo Java SDK: OpenSergoClient client = new OpenSergoClient(host, port);
client.start();
// Push-model
client.subscribeConfig(new SubscribeKey(namespace, appName, configKind),
new OpenSergoConfigSubscriber() {
@Override
public boolean onConfigUpdate(SubscribeKey subscribeKey, Object dataList) {
// Handle received config here
System.out.println("key: " + subscribeKey + ", data: " + dataList);
return true;
}
}); |
Node node = 2; | ||
|
||
repeated ServiceMetadata service_metadata = 3; | ||
reserved 4 to 16; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reserved tag conflict with docs https://github.com/opensergo/opensergo-specification/blob/main/specification/zh-Hans/README.md
maybe the docs is needed to change the tag range
是否应该将 |
对应的 proto 会提交到 opensergo-proto 项目里面;不过如何在 SDK 项目中比较方便地引用 proto,社区可以给一些更好的建议 |
refer to opensergo/opensergo-proto#3 |
PTAL!THX. 针对 issue opensergo/opensergo-proto#3 已经将 |
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
Signed-off-by: Eric Zhao <[email protected]>
…prove logs Signed-off-by: Eric Zhao <[email protected]>
…improve error handling and logs Signed-off-by: Eric Zhao <[email protected]>
Hi, I've updated the latest proto and polished SDK code (a lot of bugs has been fixed...). cc @opensergo/opensergo-maintainer |
ok, I've synchronized my fork branch https://github.com/jnan806/opensergo-java-sdk-review-sczyh30/tree/stubcode-based-sczyh30 |
Add initial implementation of OpenSergo Java client.