Fix error thrown when index configuration has no number_of_replicas specified #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecified Signed-off-by: Rupa Lahiri <[email protected]>
rblcoder
requested review from
peterzhuamazon,
prudhvigodithi,
jackson-theisen and
phillbaker
as code owners
|
@prudhvigodithi I have tested this PR with default values. |
|
Thanks @rblcoder so I assume it dint complain with the default values when executing tf apply? |
|
Also @rblcoder please try to add some unit tests to this change. Thanks |
… re-apply/update Signed-off-by: Rupa Lahiri <[email protected]>
|
@prudhvigodithi Yes, it didn't complain with default values on re-apply. Added tests. |
|
Great, thanks @rblcoder, the PR LGTM. |
prudhvigodithi
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix error thrown when index configuration has no number_of_replicas specified
Issues Resolved
#83 #108
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.