Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2.x to feature/maximus-m1 branch #979

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Oct 27, 2022

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

derek-ho and others added 30 commits October 12, 2022 15:24
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: vamsi-amazon <[email protected]>
…s-macos

feat: enable ci for windows and macos
@penghuo penghuo changed the base branch from 2.x to feature/maximus-m1 October 27, 2022 18:30
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2022

Codecov Report

Merging #979 (b286742) into feature/maximus-m1 (3a9d217) will decrease coverage by 35.19%.
The diff coverage is n/a.

@@                    Coverage Diff                    @@
##             feature/maximus-m1     #979       +/-   ##
=========================================================
- Coverage                 97.95%   62.76%   -35.20%     
=========================================================
  Files                       300       10      -290     
  Lines                      7784      658     -7126     
  Branches                    500      119      -381     
=========================================================
- Hits                       7625      413     -7212     
- Misses                      158      192       +34     
- Partials                      1       53       +52     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ain/java/org/opensearch/sql/analysis/Analyzer.java
...opensearch/sql/planner/logical/LogicalPlanDSL.java
...ensearch/sql/planner/physical/ProjectOperator.java
...rc/main/java/org/opensearch/sql/storage/Table.java
...a/org/opensearch/sql/utils/MLCommonsConstants.java
...ava/org/opensearch/sql/utils/SystemIndexUtils.java
...ch/sql/opensearch/planner/physical/ADOperator.java
...rch/planner/physical/MLCommonsOperatorActions.java
...rg/opensearch/sql/ppl/config/PPLServiceConfig.java
...java/org/opensearch/sql/ppl/parser/AstBuilder.java
... and 300 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@penghuo penghuo force-pushed the hp/feature/maximus-m1/merge branch from f4827d8 to 3df9814 Compare October 27, 2022 20:02
@penghuo penghuo force-pushed the hp/feature/maximus-m1/merge branch from 3df9814 to b286742 Compare October 27, 2022 20:52
@penghuo penghuo marked this pull request as ready for review October 27, 2022 21:36
@penghuo penghuo requested a review from a team as a code owner October 27, 2022 21:36
@penghuo penghuo merged commit 2016d5c into opensearch-project:feature/maximus-m1 Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants