Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JDBC driver jenkins CI workflow #957

Closed
wants to merge 8 commits into from
Closed

Add JDBC driver jenkins CI workflow #957

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
80ea3ed
Copy jenkinsfile from java repo.
Yury-Fridlyand Oct 21, 2022
62ad714
Update scripts.
Yury-Fridlyand Oct 22, 2022
dcacde3
Add non-shadow publishing.
Yury-Fridlyand Oct 24, 2022
6b7f5f1
Remove obsolete references.
Yury-Fridlyand Oct 24, 2022
6ed5ecd
Merge pull request #140 from Bit-Quill/dev-jdbc-jenkins-ci
Yury-Fridlyand Oct 24, 2022
e8d9a43
Address PR feedback.
Yury-Fridlyand Oct 28, 2022
79deba0
Update artifact group.
Yury-Fridlyand Oct 28, 2022
d35c17d
Fix artifact path.
Yury-Fridlyand Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jenkins/jdbc-stage-maven-release.jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pipeline {
)
}
environment {
ARTIFACT_PATH = "$WORKSPACE/build/repository/org/opensearch/client/sql/$VERSION"
ARTIFACT_PATH = "$WORKSPACE/build/repository/org/opensearch/driver/opensearch-sql-jdbc/$VERSION"
Copy link
Member

@peterzhuamazon peterzhuamazon Oct 28, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to put the jdbc in this location during ODFE.
Probably we want to keep similar subfolder structure?

https://repo1.maven.org/maven2/com/amazon/opendistroforelasticsearch/client/opendistro-sql-jdbc/

Thanks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the path where gradle places compiled jar:

$ tree build | grep -v class
build
....
├── repository
│   └── org
│       └── opensearch
│           └── driver
│               └── opensearch-sql-jdbc
│                   ├── 2.0.0.0
│                   │   ├── opensearch-sql-jdbc-2.0.0.0.jar
....

In general, there is the same structure, but we renamed

  • com.amazon to org.opensearch
  • opendistroforelasticsearch and opendistro to opensearch
  • client to driver

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I revert this?

}
stages {
stage('Publish to Maven Local') {
Expand Down