Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated png file #865

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Sep 28, 2022

Signed-off-by: Joshua Li [email protected]

Description

Fixes this problem on case-insensitive filesystem (mac default)

❯ git clone ...
warning: the following paths have collided (e.g. case-sensitive paths
on a case-insensitive filesystem) and only one from the same
colliding group is in the working tree:

  'sql-jdbc/docs/img/tableau_graph.PNG'
  'sql-jdbc/docs/img/tableau_graph.png'

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 requested a review from a team as a code owner September 28, 2022 23:18
@codecov-commenter
Copy link

Codecov Report

Merging #865 (1b99f9e) into 2.x (3ca6450) will decrease coverage by 35.08%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                2.x     #865       +/-   ##
=============================================
- Coverage     97.85%   62.76%   -35.09%     
=============================================
  Files           281       10      -271     
  Lines          7357      658     -6699     
  Branches        467      119      -348     
=============================================
- Hits           7199      413     -6786     
- Misses          157      192       +35     
- Partials          1       53       +52     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...opensearch/sql/data/model/ExprCollectionValue.java
...g/opensearch/sql/data/model/ExprDatetimeValue.java
...pensearch/sql/ppl/parser/AstExpressionBuilder.java
...ggregation/ExpressionAggregationScriptFactory.java
...search/sql/expression/datetime/IntervalClause.java
...arch/sql/expression/aggregation/MinAggregator.java
...org/opensearch/sql/analysis/QualifierAnalyzer.java
...a/org/opensearch/sql/analysis/TypeEnvironment.java
...pensearch/sql/planner/physical/ValuesOperator.java
...h/sql/opensearch/data/type/OpenSearchDataType.java
... and 281 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added bug Something isn't working JDBC labels Sep 29, 2022
@dai-chen
Copy link
Collaborator

Do you know in which case will this happen? I didn't recall I've ever met this problem on mac..

@joshuali925
Copy link
Member Author

Do you know in which case will this happen? I didn't recall I've ever met this problem on mac..

There are 2 tableau_graph.png files under this directory: https://github.com/opensearch-project/sql/tree/2.x/sql-jdbc/docs/img

On mac default settings files are case insensitive, meaning it's impossible to check both png out because they have the same filename. Not sure why doesn't happen to you but it causes warning at clone on my mac and some issues on git status and rsync to linux. Also the file is not necessary anyways.

@dai-chen
Copy link
Collaborator

Do you know in which case will this happen? I didn't recall I've ever met this problem on mac..

There are 2 tableau_graph.png files under this directory: https://github.com/opensearch-project/sql/tree/2.x/sql-jdbc/docs/img

On mac default settings files are case insensitive, meaning it's impossible to check both png out because they have the same filename. Not sure why doesn't happen to you but it causes warning at clone on my mac and some issues on git status and rsync to linux. Also the file is not necessary anyways.

I see. Probably I ignored the error. Thanks!

@dai-chen dai-chen merged commit 9210c5f into opensearch-project:2.x Sep 29, 2022
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 3, 2022
GabeFernandez310 pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants