-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated png file #865
Conversation
Signed-off-by: Joshua Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #865 +/- ##
=============================================
- Coverage 97.85% 62.76% -35.09%
=============================================
Files 281 10 -271
Lines 7357 658 -6699
Branches 467 119 -348
=============================================
- Hits 7199 413 -6786
- Misses 157 192 +35
- Partials 1 53 +52
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Do you know in which case will this happen? I didn't recall I've ever met this problem on mac.. |
There are 2 tableau_graph.png files under this directory: https://github.com/opensearch-project/sql/tree/2.x/sql-jdbc/docs/img On mac default settings files are case insensitive, meaning it's impossible to check both png out because they have the same filename. Not sure why doesn't happen to you but it causes warning at clone on my mac and some issues on git status and rsync to linux. Also the file is not necessary anyways. |
I see. Probably I ignored the error. Thanks! |
Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li [email protected]
Description
Fixes this problem on case-insensitive filesystem (mac default)
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.