ODBC SSL Compliance Fix #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oint bug when using SSL without protocol specified in url Signed-off-by: forestmvey <[email protected]>
…he url Signed-off-by: forestmvey <[email protected]>
…tribution node Signed-off-by: forestmvey <[email protected]>
… url and/or incompatible with server url Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
…ut server url generation into own function. Minor logic revisions. Signed-off-by: forestmvey <[email protected]>
…ausing an unusable UI state for windows users. Signed-off-by: forestmvey <[email protected]>
…failure to establish connection with url Signed-off-by: forestmvey <[email protected]>
…g valid server URL's with string_view usage. Signed-off-by: forestmvey <[email protected]>
ODBC SSL Compliance Fix
Codecov Report
@@ Coverage Diff @@
## main opensearch-project/sql#653 +/- ##
============================================
+ Coverage 94.57% 94.63% +0.06%
- Complexity 2743 2777 +34
============================================
Files 278 279 +1
Lines 7430 7517 +87
Branches 554 556 +2
============================================
+ Hits 7027 7114 +87
Misses 349 349
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
penghuo
reviewed
Jun 23, 2022
| @@ -120,7 +120,7 @@ extern "C" { | |||
| #define DEFAULT_BOOLSASCHAR 0 | |||
| #define DEFAULT_UNIQUEINDEX 1 /* dont recognize */ | |||
| #define DEFAULT_LOGLEVEL OPENSEARCH_WARNING | |||
| #define DEFAULT_USE_SSL 0 | |||
| #define DEFAULT_USE_SSL 1 | |||
There was a problem hiding this comment.
Is there any doc should be change accordingly?
There was a problem hiding this comment.
I could not find any reference to a default value for the use of SSL. We will make a ticket to update this page with at least a reference to download the driver.
https://opensearch.org/docs/latest/search-plugins/sql/odbc/
There was a problem hiding this comment.
And also to note the defaults for the ODBC driver.
|
Demo video for this fix: Issue-280 |
acarbonetto
approved these changes
Jun 27, 2022
joshuali925
approved these changes
Jun 27, 2022
andy-k-improving
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Nov 16, 2024
Signed-off-by: John Mazanec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed ODBC Driver Issues:
https://prefixIssues Resolved
Issue: 280
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.