Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add implementation for simple_query_string relevance search function in SQL and PPL #635

Merged

Conversation

Yury-Fridlyand
Copy link
Collaborator

Description

Issues Resolved

#192

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner June 6, 2022 23:46
@codecov-commenter
Copy link

Codecov Report

Merging #635 (30bc724) into main (26058b8) will decrease coverage by 31.81%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #635       +/-   ##
=============================================
- Coverage     94.57%   62.76%   -31.82%     
=============================================
  Files           278       10      -268     
  Lines          7430      658     -6772     
  Branches        554      119      -435     
=============================================
- Hits           7027      413     -6614     
+ Misses          349      192      -157     
+ Partials         54       53        -1     
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java
...opensearch/sql/data/model/ExprCollectionValue.java
...c/main/java/org/opensearch/sql/expression/DSL.java
...ensearch/sql/expression/ExpressionNodeVisitor.java
...h/sql/expression/function/BuiltinFunctionName.java
...h/sql/expression/function/OpenSearchFunctions.java
...arch/storage/script/filter/FilterQueryBuilder.java
...pensearch/sql/ppl/parser/AstExpressionBuilder.java
...pensearch/sql/sql/parser/AstExpressionBuilder.java
...org/opensearch/sql/data/model/ExprDoubleValue.java
... and 258 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26058b8...30bc724. Read the comment docs.

Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuali925 joshuali925 merged commit d81ef73 into opensearch-project:main Jun 13, 2022
@joshuali925 joshuali925 mentioned this pull request Jun 13, 2022
6 tasks
@Yury-Fridlyand Yury-Fridlyand deleted the dev-simple_query_string-#192 branch June 14, 2022 02:08
@Yury-Fridlyand Yury-Fridlyand restored the dev-simple_query_string-#192 branch June 14, 2022 02:13
@Yury-Fridlyand Yury-Fridlyand deleted the dev-simple_query_string-#192 branch June 14, 2022 02:15
andy-k-improving pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Nov 16, 2024
Adjusted com.github.seancfoley:ipaddress version to address CVE.
Adjusted org.apache.commons:commons-compress to address CVE.
Added commons-io:commons-io due to above update.

Signed-off-by: Vijayan Balasubramanian <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants