-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate workbench to OpenSearch Dashboards #6
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2db19a8
migrate to opensearch
davidcui1225 59dd41f
rename dir in readme
davidcui1225 4d7cc7b
update test and build workflow
davidcui1225 3b2032b
use opensearch dashboards over kibana
davidcui1225 299eb14
add renaming changes
davidcui1225 eb0b464
update release workflow and tslint ES BV license statement
davidcui1225 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
Open Distro for Elasticsearch SQL Kibana Plugin | ||
OpenSearch Dashboards SQL Plugin | ||
Copyright 2018-2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
# Open Distro for Elasticsearch Query Workbench | ||
# OpenSearch Dashboards Query Workbench | ||
|
||
The Open Distro for Elasticsearch Query Workbench enables you to query your Elasticsearch data using either SQL or PPL syntax from a dedicated Kibana UI. You can download your query results data in JSON, JDBC, CSV and raw text formats. | ||
The OpenSearch Dashboards Query Workbench enables you to query your OpenSearch data using either SQL or PPL syntax from a dedicated OpenSearch Dashboards UI. You can download your query results data in JSON, JDBC, CSV and raw text formats. | ||
|
||
|
||
## Documentation | ||
|
@@ -10,29 +10,29 @@ Please see our technical [documentation](https://opendistro.github.io/for-elasti | |
|
||
## Setup | ||
|
||
1. Download Elasticsearch for the version that matches the [Kibana version specified in package.json](./package.json#L8). | ||
1. Download and install the most recent version of [Open Distro for Elasticsearch SQL plugin](https://github.com/opendistro-for-elasticsearch/sql). | ||
1. Download the Kibana source code for the [version specified in package.json](./package.json#L8) you want to set up. | ||
1. Download OpenSearch for the version that matches the [OpenSearch Dashboards version specified in package.json](./package.json#L8). | ||
1. Download and install the most recent version of [OpenSearch SQL plugin](https://github.com/opensearch-project/sql#open-distro-for-elasticsearch-sql). | ||
1. Download the OpenSearch Dashboards source code for the [version specified in package.json](./package.json#L8) you want to set up. | ||
|
||
See the [Kibana contributing guide](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#setting-up-your-development-environment) for more instructions on setting up your development environment. | ||
See the [OpenSearch Dashboards contributing guide](https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/CONTRIBUTING.md) to get started. | ||
|
||
1. Change your node version to the version specified in `.node-version` inside the Kibana root directory. | ||
1. cd into the Kibana source code directory. | ||
1. Change your node version to the version specified in `.node-version` inside the OpenSearch Dashboards root directory. | ||
1. cd into the OpenSearch Dashboards source code directory. | ||
1. Check out this package from version control into the `plugins` directory. | ||
``` | ||
git clone [email protected]:opendistro-for-elasticsearch/sql.git plugins --no-checkout | ||
git clone [email protected]:opensearch-project/sql.git plugins --no-checkout | ||
cd plugins | ||
echo 'workbench/*' >> .git/info/sparse-checkout | ||
git config core.sparseCheckout true | ||
git checkout master | ||
git checkout main | ||
``` | ||
6. Run `yarn kbn bootstrap` inside `kibana/plugins/workbench`. | ||
6. Run `yarn osd bootstrap` inside `OpenSearch-Dashboards/plugins/workbench`. | ||
davidcui1225 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Ultimately, your directory structure should look like this: | ||
|
||
```md | ||
. | ||
├── kibana | ||
├── OpenSearch-Dashboards | ||
davidcui1225 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
│ └── plugins | ||
│ └── workbench | ||
``` | ||
|
@@ -49,21 +49,21 @@ Example output: `./build/opendistro-query-workbench-*.zip` | |
|
||
- `yarn start` | ||
|
||
Starts Kibana and includes this plugin. Kibana will be available on `localhost:5601`. | ||
Starts OpenSearch Dashboards and includes this plugin. OpenSearch Dashboards will be available on `localhost:5601`. | ||
|
||
- `NODE_PATH=../../node_modules yarn test:jest` | ||
|
||
Runs the plugin tests. | ||
|
||
|
||
## Contributing to Open Distro for Elasticsearch Query Workbench | ||
## Contributing to OpenSearch SQL Workbench | ||
|
||
- Refer to [CONTRIBUTING.md](./CONTRIBUTING.md). | ||
- Since this is a workbench, it can be useful to review the [Kibana contributing guide](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md) alongside the documentation around [workbenchs](https://www.elastic.co/guide/en/kibana/master/kibana-plugins.html) and [plugin development](https://www.elastic.co/guide/en/kibana/master/plugin-development.html). | ||
- We welcome you to get involved in development, documentation, testing the OpenSearch SQL Workbench plugin. See our [CONTRIBUTING.md](./CONTRIBUTING.md) and join in. | ||
|
||
## Bugs, Enhancements or Questions | ||
|
||
Please file an issue to report any bugs you may find, enhancements you may need or questions you may have [here](https://github.com/opendistro-for-elasticsearch/sql/issues). | ||
Please file an issue to report any bugs you may find, enhancements you may need or questions you may have [here](https://github.com/opensearch-project/sql/issues). | ||
|
||
## License | ||
|
||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
{ | ||
"id": "queryWorkbenchDashboards", | ||
"version": "1.15.0.0", | ||
"opensearchDashboardsVersion": "7.10.2", | ||
"server": true, | ||
"ui": true, | ||
"requiredPlugins": ["navigation"], | ||
"optionalPlugins": [] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,21 @@ | ||
{ | ||
"name": "opendistro-query-workbench", | ||
"version": "1.13.0.0", | ||
"version": "1.15.0.0", | ||
"description": "Query Workbench", | ||
"main": "index.js", | ||
"license": "Apache-2.0", | ||
"homepage": "https://github.com/opendistro-for-elasticsearch/sql/tree/master/workbench", | ||
"kibana": { | ||
"homepage": "https://github.com/opensearch-project/sql/tree/main/workbench", | ||
"opensearchDashboards": { | ||
"version": "7.10.2", | ||
"templateVersion": "6.3.3" | ||
}, | ||
"repository": { | ||
"type": "git", | ||
"url": "https://github.com/opendistro-for-elasticsearch/sql/tree/master/workbench" | ||
"url": "https://github.com/opensearch-project/sql/tree/main/workbench" | ||
}, | ||
"scripts": { | ||
"kbn": "node ../../scripts/kbn", | ||
"osd": "node ../../scripts/osd", | ||
"opensearch": "node ../../scripts/opensearch", | ||
"lint": "tslint .", | ||
"start": "plugin-helpers start", | ||
"test:server": "plugin-helpers test:server", | ||
|
@@ -28,7 +29,6 @@ | |
"react-double-scrollbar": "^0.0.15" | ||
}, | ||
"devDependencies": { | ||
"@elastic/eslint-import-resolver-kibana": "link:../../packages/kbn-eslint-import-resolver-kibana", | ||
"@types/hapi-latest": "npm:@types/[email protected]", | ||
"@types/react-router-dom": "^5.1.5", | ||
"cypress": "^5.0.0", | ||
|
@@ -57,8 +57,6 @@ | |
"**/@types/react-dom": "^16.0.5", | ||
"**/@types/react-router-dom": "^4.3.1", | ||
"eslint-utils": "^2.0.0", | ||
"**/@types/react": "16.3.14", | ||
"lodash": "^4.17.21", | ||
"ssri": "8.0.1" | ||
"**/@types/react": "16.3.14" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think paths should remain lowercase. + below many
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the
OpenSearch-Dashboards
repo has the upper case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. In hindsight maybe we should have made repo names lowercase, but YOLO.