Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removign JDK14 from CI #547

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Conversation

vmmusings
Copy link
Member

@vmmusings vmmusings commented Apr 11, 2022

Signed-off-by: vamsi-amazon [email protected]

Description

Removing JDK14 from CI as we will be only supporting Java LTS versions(11&17) from 2.0 release.

Issues Resolved

#522

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: vamsi-amazon <[email protected]>
@vmmusings vmmusings requested a review from a team as a code owner April 11, 2022 19:06
@codecov-commenter
Copy link

Codecov Report

Merging #547 (61741b7) into main (9b43d3f) will decrease coverage by 32.47%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main     #547       +/-   ##
=============================================
- Coverage     95.23%   62.76%   -32.48%     
=============================================
  Files           276       10      -266     
  Lines          7410      658     -6752     
  Branches        537      118      -419     
=============================================
- Hits           7057      413     -6644     
+ Misses          299      192      -107     
+ Partials         54       53        -1     
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../opensearch/sql/planner/logical/LogicalRemove.java
...l/expression/window/ranking/RowNumberFunction.java
...earch/storage/script/filter/lucene/RangeQuery.java
...h/sql/expression/function/BuiltinFunctionName.java
...search/sql/data/model/AbstractExprNumberValue.java
...request/system/OpenSearchDescribeIndexRequest.java
...nsearch/sql/expression/aggregation/Aggregator.java
...arch/storage/script/filter/FilterQueryBuilder.java
...ch/storage/script/filter/lucene/WildcardQuery.java
...l/expression/window/frame/PeerRowsWindowFrame.java
... and 256 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b43d3f...61741b7. Read the comment docs.

@vmmusings vmmusings merged commit 1cda685 into opensearch-project:main Apr 11, 2022
@penghuo penghuo mentioned this pull request Apr 12, 2022
vmmusings added a commit that referenced this pull request Apr 19, 2022
Signed-off-by: vamsi-amazon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants