Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix, return default ID when log4j ThreadContext is empty #538

Merged
merged 1 commit into from
Apr 5, 2022

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Apr 5, 2022

Signed-off-by: penghuo [email protected]

Description

Bug Fix, return default ID when log4j ThreadContext is empty.

Issues Resolved

#537

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • [] New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo requested a review from a team as a code owner April 5, 2022 17:56
Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@penghuo penghuo merged commit 54b7257 into opensearch-project:main Apr 5, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2022
penghuo added a commit that referenced this pull request Apr 7, 2022
…539)

Signed-off-by: penghuo <[email protected]>
(cherry picked from commit 54b7257)

Co-authored-by: Peng Huo <[email protected]>
opensearch-trigger-bot bot added a commit that referenced this pull request Apr 7, 2022
…539)

Signed-off-by: penghuo <[email protected]>
(cherry picked from commit 54b7257)

Co-authored-by: Peng Huo <[email protected]>
(cherry picked from commit 7e215ff)
penghuo pushed a commit that referenced this pull request Apr 8, 2022
vmmusings pushed a commit that referenced this pull request Apr 19, 2022
ps48 added a commit that referenced this pull request Jul 28, 2022
* Disable flaky test in JdbcTestIT. (#475)

Signed-off-by: penghuo <[email protected]>

* Update dependency opensearch-ml-client group name (#477)

Signed-off-by: jackieyanghan <[email protected]>

* Collected fixes related to bugs #280, #302, #783, #696 and 317 all together. (#479)

Signed-off-by: Yury Fridlyand <[email protected]>

* Add JDK 8 to CI Matrix  (#483) (#484)

* fixed references in java 8 and added to ci matrix
* filter test that fails due to jdk 8 bug
* use different degree to radian conversion for difference in jdk
* skip date time format tests that cause error due to jdk bug
* only disable DateTime unit test on Java 8

Bypassing failed DCO check

Signed-off-by: David Cui <[email protected]>
(cherry picked from commit b6fccbd)

Co-authored-by: David Cui <[email protected]>

* Add parse docs to PPL commands index (#486) (#487)

Signed-off-by: Joshua Li <[email protected]>

* Add 1.3.0 release notes (#492)

Signed-off-by: Eugene Lee <[email protected]>

* Add Kmeans and AD command documentation (#493) (#497)

Signed-off-by: jackieyanghan <[email protected]>
(cherry picked from commit ee4bce0)

* Bump version to 1.3.1

Signed-off-by: Sayali Gaikawad <[email protected]>

* Bump ml

Signed-off-by: Sayali Gaikawad <[email protected]>

* Add new zip

Signed-off-by: Sayali Gaikawad <[email protected]>

* Updated release drafter

Signed-off-by: Sayali Gaikawad <[email protected]>

* Remove checked-in ml-commons dependency (#529)

Signed-off-by: jackieyanghan <[email protected]>

* Bump workbench to 1.3.1 (#540)

Signed-off-by: Joshua Li <[email protected]>

* Bug Fix, return default ID when log4j ThreadContext is empty (#538) (#539) (#543)

Signed-off-by: penghuo <[email protected]>
(cherry picked from commit 54b7257)

* Incremented version to 1.3.2. (#593)

Signed-off-by: Zelin Hao <[email protected]>
Signed-off-by: Joshua Li <[email protected]>

Co-authored-by: Joshua Li <[email protected]>

* Version bump 1.3.3

Signed-off-by: pgodithi <[email protected]>

* [1.3] Bump spring-beans to 5.2.20 (#632)

Signed-off-by: Joshua Li <[email protected]>

* Version bump 1.3.3

Signed-off-by: pgodithi <[email protected]>

* Incremented version to 1.3.4. (#681)

* Incremented version to 1.3.4.

Signed-off-by: Zelin Hao <[email protected]>

* bump jackson to 2.13.2

Signed-off-by: Joshua Li <[email protected]>

Co-authored-by: Joshua Li <[email protected]>

Co-authored-by: Peng Huo <[email protected]>
Co-authored-by: Jackie Han <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: David Cui <[email protected]>
Co-authored-by: Eugene Lee <[email protected]>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Sayali Gaikawad <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
Co-authored-by: Zelin Hao <[email protected]>
Co-authored-by: pgodithi <[email protected]>
Co-authored-by: Anirudha (Ani) Jadhav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants