Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 build fix #535

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

vamsi-amazon
Copy link
Member

@vamsi-amazon vamsi-amazon commented Apr 5, 2022

Signed-off-by: vamsi-amazon [email protected]

Description

Jenkins build is failing with JDK campatability issues. More details: #534

Issues Resolved

#534

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: vamsi-amazon <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

Merging #535 (1e2671e) into main (d3a76c9) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #535   +/-   ##
=========================================
  Coverage     95.23%   95.23%           
  Complexity     2744     2744           
=========================================
  Files           276      276           
  Lines          7410     7410           
  Branches        537      538    +1     
=========================================
  Hits           7057     7057           
  Misses          299      299           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.76% <ø> (ø)
sql-engine 98.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3a76c9...1e2671e. Read the comment docs.

Signed-off-by: vamsi-amazon <[email protected]>
@vamsi-amazon vamsi-amazon marked this pull request as ready for review April 5, 2022 05:03
@vamsi-amazon vamsi-amazon requested a review from a team as a code owner April 5, 2022 05:03
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@penghuo penghuo added the v2.0.0 label Apr 5, 2022
@vamsi-amazon vamsi-amazon merged commit 0a4ae66 into opensearch-project:main Apr 5, 2022
vamsi-amazon added a commit that referenced this pull request Apr 19, 2022
* 2.0 build fix

Signed-off-by: vamsi-amazon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants