Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremented version to 1.3.2. #526

Closed
wants to merge 1 commit into from

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Apr 1, 2022

Signed-off-by: Sayali Rohidas Gaikawad [email protected]

Coming from opensearch-project/opensearch-build#1805 post release activity.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Rohidas Gaikawad <[email protected]>
@gaiksaya gaiksaya requested a review from a team as a code owner April 1, 2022 01:46
@codecov-commenter
Copy link

Codecov Report

Merging #526 (c6756f9) into 1.3 (20bff4c) will decrease coverage by 32.33%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                1.3     #526       +/-   ##
=============================================
- Coverage     95.25%   62.91%   -32.34%     
=============================================
  Files           276       10      -266     
  Lines          7416      658     -6758     
  Branches        545      119      -426     
=============================================
- Hits           7064      414     -6650     
+ Misses          298      191      -107     
+ Partials         54       53        -1     
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../opensearch/sql/planner/physical/PhysicalPlan.java
...pensearch/sql/planner/logical/LogicalRareTopN.java
...ript/aggregation/dsl/MetricAggregationBuilder.java
...sql/expression/aggregation/AggregatorFunction.java
...a/org/opensearch/sql/utils/MLCommonsConstants.java
...age/serialization/DefaultExpressionSerializer.java
...org/opensearch/sql/opensearch/client/MLClient.java
.../opensearch/sql/planner/logical/LogicalWindow.java
.../org/opensearch/sql/data/model/ExprShortValue.java
...opensearch/response/error/ErrorMessageFactory.java
... and 256 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20bff4c...c6756f9. Read the comment docs.

@dai-chen
Copy link
Collaborator

SQL CI failed?

@gaiksaya
Copy link
Member Author

SQL CI failed?

Yes looks like it is not able to find the ml-client. Any idea how to resolve this?
Thanks!

@joshuali925 joshuali925 mentioned this pull request Apr 28, 2022
6 tasks
@penghuo
Copy link
Collaborator

penghuo commented May 19, 2022

@gaiksaya should we close this PR in case 1.3.2 already in there.
#593

@joshuali925
Copy link
Member

closing, duplicate of #593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants