Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bwc build issue with jdk17 #520

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Mar 29, 2022

Signed-off-by: penghuo [email protected]

Description

Java 17 bwc test failed, because of
Could not find matching constructor for: java.io.File(String, File)

https://github.com/opensearch-project/sql/runs/5725756591?check_suite_focus=true

Issues Resolved

None

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@penghuo penghuo requested a review from a team as a code owner March 29, 2022 21:06
@penghuo penghuo assigned dai-chen, vmmusings and penghuo and unassigned dai-chen and vmmusings Mar 29, 2022
@penghuo penghuo added the v2.0.0 label Mar 29, 2022
@penghuo penghuo requested review from dai-chen and vmmusings March 29, 2022 21:07
Copy link
Member

@vmmusings vmmusings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@codecov-commenter
Copy link

Codecov Report

Merging #520 (7c4a653) into main (ab9c1fb) will increase coverage by 3.15%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #520      +/-   ##
============================================
+ Coverage     95.24%   98.40%   +3.15%     
  Complexity     2744     2744              
============================================
  Files           276      266      -10     
  Lines          7410     6752     -658     
  Branches        537      419     -118     
============================================
- Hits           7058     6644     -414     
+ Misses          298      107     -191     
+ Partials         54        1      -53     
Flag Coverage Δ
query-workbench ?
sql-engine 98.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/public/components/QueryResults/QueryResults.tsx
...ublic/components/QueryResults/QueryResultsBody.tsx
workbench/public/components/Main/main.tsx
...h/public/components/QueryLanguageSwitch/Switch.tsx
workbench/public/components/PPLPage/PPLPage.tsx
workbench/public/components/Header/Header.tsx
workbench/public/components/SQLPage/SQLPage.tsx
workbench/public/utils/PanelWrapper.tsx
workbench/public/components/app.tsx
workbench/public/application.tsx

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69affa5...7c4a653. Read the comment docs.

@penghuo penghuo merged commit 2dbfc18 into opensearch-project:main Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants