Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.3.1 #517

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Bump version to 1.3.1 #517

merged 4 commits into from
Mar 29, 2022

Conversation

gaiksaya
Copy link
Member

Signed-off-by: Sayali Gaikawad [email protected]

Description

Bump version to 1.3.1

Issues Resolved

opensearch-project/opensearch-build#1805

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya gaiksaya requested a review from a team as a code owner March 26, 2022 00:35
@gaiksaya
Copy link
Member Author

Hi @opensearch-project/sql team, can someone look into the failing CI and let me know what more needs to change here?
Thanks!

@dai-chen
Copy link
Collaborator

2022-03-28T22:25:01.0633301Z | Exception in thread "main" java.lang.IllegalArgumentException: Plugin [opensearch-ml] was built for OpenSearch version 1.3.0 but version 1.3.1 is running
2022-03-28T22:25:01.0633956Z | 	at org.opensearch.plugins.PluginsService.verifyCompatibility(PluginsService.java:392)
2022-03-28T22:25:01.0634612Z | 	at org.opensearch.plugins.InstallPluginCommand.loadPluginInfo(InstallPluginCommand.java:815)
2022-03-28T22:25:01.0635278Z | 	at org.opensearch.plugins.InstallPluginCommand.installPlugin(InstallPluginCommand.java:870)
2022-03-28T22:25:01.0635914Z | 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:275)
2022-03-28T22:25:01.0636507Z | 	at org.opensearch.plugins.InstallPluginCommand.execute(InstallPluginCommand.java:249)
2022-03-28T22:25:01.0637112Z | 	at org.opensearch.cli.EnvironmentAwareCommand.execute(EnvironmentAwareCommand.java:100)
2022-03-28T22:25:01.0637689Z | 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
2022-03-28T22:25:01.0638209Z | 	at org.opensearch.cli.MultiCommand.execute(MultiCommand.java:104)
2022-03-28T22:25:01.0638714Z | 	at org.opensearch.cli.Command.mainWithoutErrorHandling(Command.java:138)
2022-03-28T22:25:01.0639194Z | 	at org.opensearch.cli.Command.main(Command.java:101)
2022-03-28T22:25:01.0639637Z | 	at org.opensearch.plugins.PluginCli.main(PluginCli.java:60)

Need to bump dependency plugin version as well?

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya
Copy link
Member Author

gaiksaya commented Mar 28, 2022

Need to bump dependency plugin version as well?

Missed it. Bumped it now. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2022

Codecov Report

Merging #517 (2cd49a5) into 1.3 (be42907) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                1.3     #517   +/-   ##
=========================================
  Coverage     95.25%   95.25%           
  Complexity     2746     2746           
=========================================
  Files           276      276           
  Lines          7416     7416           
  Branches        545      545           
=========================================
  Hits           7064     7064           
  Misses          298      298           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be42907...2cd49a5. Read the comment docs.

@dai-chen
Copy link
Collaborator

It seems the same opensearch-ml-client error. Could we refer to other repo and check if any change missed? Or ask help from ML client owner?

@joshuali925
Copy link
Member

doctest/resources/ml-commons/opensearch-ml-1.3.0.0-SNAPSHOT.zip
this also needs to be 1.3.1?

Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya
Copy link
Member Author

Thanks for the help @dai-chen and @joshuali925 . Please review since all tests have passed.

Signed-off-by: Sayali Gaikawad <[email protected]>
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

Copy link
Collaborator

@dai-chen dai-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@gaiksaya gaiksaya merged commit 20bff4c into opensearch-project:1.3 Mar 29, 2022
@gaiksaya gaiksaya deleted the 1.3.1 branch March 29, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants