Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed changes introduced to support JDK8 #513

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

vmmusings
Copy link
Member

Signed-off-by: vamsi-amazon [email protected]

Description

Removed changes introduced to support JDK8.

Issues Resolved

#466

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2022

Codecov Report

Merging #513 (adbcb70) into main (6771968) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main     #513   +/-   ##
=========================================
  Coverage     95.24%   95.24%           
  Complexity     2744     2744           
=========================================
  Files           276      276           
  Lines          7410     7410           
  Branches        537      537           
=========================================
  Hits           7058     7058           
  Misses          298      298           
  Partials         54       54           
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine 98.40% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/opensearch/sql/expression/text/TextFunction.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6771968...adbcb70. Read the comment docs.

@vmmusings vmmusings marked this pull request as ready for review March 24, 2022 22:29
@vmmusings vmmusings requested a review from a team as a code owner March 24, 2022 22:29
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmmusings vmmusings merged commit 217b100 into opensearch-project:main Mar 25, 2022
andy-k-improving pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants