Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.x] Add JDK 8 to CI Matrix #499

Merged
merged 1 commit into from
Mar 16, 2022
Merged

[Backport 1.x] Add JDK 8 to CI Matrix #499

merged 1 commit into from
Mar 16, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport b6fccbd from #483

@davidcui1225 @github-actions
Add JDK 8 to CI Matrix (#483)
7b2feb7 
* fixed references in java 8 and added to ci matrix
* filter test that fails due to jdk 8 bug
* use different degree to radian conversion for difference in jdk
* skip date time format tests that cause error due to jdk bug
* only disable DateTime unit test on Java 8

Signed-off-by: David Cui <[email protected]>
(cherry picked from commit b6fccbd)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 15, 2022 20:57
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022 •
edited
Loading

Codecov Report

Merging #499 (7b2feb7) into 1.x (e131196) will decrease coverage by 32.33%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##                1.x     #499       +/-   ##
=============================================
- Coverage     95.25%   62.91%   -32.34%     
=============================================
  Files           276       10      -266     
  Lines          7414      658     -6756     
  Branches        537      118      -419     
=============================================
- Hits           7062      414     -6648     
+ Misses          298      191      -107     
+ Partials         54       53        -1
Flag Coverage Δ
query-workbench 62.91% <ø> (ø)
sql-engine ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/main/java/org/opensearch/sql/expression/DSL.java
...g/opensearch/sql/expression/text/TextFunction.java
...ensearch/sql/exception/SemanticCheckException.java
...h/sql/expression/function/BuiltinFunctionName.java
...protocol/response/format/RawResponseFormatter.java
...pensearch/data/value/OpenSearchDateFormatters.java
...ch/sql/expression/aggregation/CountAggregator.java
...arch/sql/expression/datetime/DateTimeFunction.java
...sql/opensearch/response/agg/SingleValueParser.java
...earch/sql/expression/window/frame/WindowFrame.java
... and 256 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e131196...7b2feb7. Read the comment docs.

penghuo
penghuo approved these changes Mar 16, 2022
View reviewed changes
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@penghuo penghuo merged commit 325a757 into 1.x Mar 16, 2022
@github-actions github-actions bot deleted the backport/backport-483-to-1.x branch March 16, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@penghuo penghuo penghuo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codecov-commenter @penghuo @joshuali925 @davidcui1225