Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.2] Bump gson and json-schema #371

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

backport #370

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 self-assigned this Jan 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #371 (14b7c94) into 1.2 (f14b534) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                1.2     #371   +/-   ##
=========================================
  Coverage     99.90%   99.90%           
  Complexity     2687     2687           
=========================================
  Files           256      256           
  Lines          6524     6524           
  Branches        420      420           
=========================================
  Hits           6518     6518           
  Misses            5        5           
  Partials          1        1           
Flag Coverage Δ
sql-engine 99.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14b534...14b7c94. Read the comment docs.

@joshuali925 joshuali925 requested a review from a team January 11, 2022 22:41
@ps48 ps48 requested a review from davidcui1225 January 11, 2022 23:06
@joshuali925 joshuali925 merged commit b0b4af7 into opensearch-project:1.2 Jan 11, 2022
andy-k-improving pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Nov 16, 2024
…roject#371)

1. Added datasource name validation in delete/update api
2. Added datasource name validation in processor creation method
3. Changed index name delimiter from `.` to `-` to be consistent with others

Signed-off-by: Heemin Kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants