-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set baseline JDK version to JDK-21 #2787
Conversation
e67c66f
to
102b598
Compare
5ca1d9a
to
f9b0786
Compare
let's fix CI and security check, thanks! |
Looks like Whitesource security check scanner has failed to scan the repo and seems unrelated to this change. For BWC test failure here https://github.com/opensearch-project/sql/actions/runs/9719035598/job/26828118379?pr=2787 I see below error
which also seems to be not related to the upgrade change. Can you help me understand how can I fix this if it is related to my change? |
Could you rerun whitesource? As per the CI, could you try |
Yes in local I see this error
Similar to Derek's PR, this seems to be related to not finding the artifacts for Darwin x64 platform. |
@peterzhuamazon Hi Peter, we are having BWC test failures in our CI because of not finding Darwin artifacts for 2.15. Is this known issue? |
Test is on Linux, not related MacOS Should we bump String baseVersion = "2.15.0" to 2.16.0 now? |
Depend on #2743 |
Yes the base version should be bumped |
Signed-off-by: Manasvini B S <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx!
@manasvinibs This PR incorporates many changes in ANTLR grammar automatically. Can we backport this If concern, I think we need to create a PR manually with only grammar changes. Otherwise, we may miss those changes in all 2.x release. |
Signed-off-by: Manasvini B S <[email protected]>
Description
Sets the baseline JDK version to JDK-21
Issues Resolved
#2713