Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seder to TransportPPLQueryResponse #2452

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

zane-neo
Copy link
Contributor

@zane-neo zane-neo commented Dec 8, 2023

Description

Add seder to TransportPPLQueryResponse

Issues Resolved

Add seder to TransportPPLQueryResponse

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0176525) 95.40% compared to head (48708be) 95.40%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2452   +/-   ##
=========================================
  Coverage     95.40%   95.40%           
  Complexity     5000     5000           
=========================================
  Files           479      479           
  Lines         13939    13939           
  Branches        937      937           
=========================================
  Hits          13299    13299           
  Misses          618      618           
  Partials         22       22           
Flag Coverage Δ
sql-engine 95.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dai-chen dai-chen added enhancement New feature or request backport 2.x labels Dec 8, 2023
@dai-chen
Copy link
Collaborator

dai-chen commented Dec 8, 2023

The only CI failure seems not relevant. Will merge this PR.

2023-12-08T17:19:53.8294820Z > Task :doctest:doctest FAILED
2023-12-08T17:19:53.8295380Z ======================================================================
2023-12-08T17:19:53.8295850Z 
2023-12-08T17:19:53.8296160Z ERROR: test_docs (unittest.loader._FailedTest.test_docs)
2023-12-08T17:19:53.8296880Z > Task :doctest:stopOpenSearch
2023-12-08T17:19:53.8297730Z ----------------------------------------------------------------------
2023-12-08T17:19:53.8298500Z ImportError: Failed to import test module: test_docs
2023-12-08T17:19:53.8299200Z Traceback (most recent call last):
2023-12-08T17:19:53.8300480Z   File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/unittest/loader.py", line 129, in loadTestsFromName
2023-12-08T17:19:53.8301840Z     module = __import__(module_name)
2023-12-08T17:19:53.8302360Z              ^^^^^^^^^^^^^^^^^^^^^^^
2023-12-08T17:19:53.8303180Z   File "/Users/runner/work/sql/sql/doctest/test_docs.py", line 16, in <module>
2023-12-08T17:19:53.8304380Z     from opensearch_sql_cli.opensearch_connection import OpenSearchConnection
2023-12-08T17:19:53.8306110Z   File "/Users/runner/work/sql/sql/doctest/sql-cli/src/opensearch_sql_cli/opensearch_connection.py", line 6, in <module>
2023-12-08T17:19:53.8307410Z     import boto3
2023-12-08T17:19:53.8308590Z   File "/Users/runner/work/sql/sql/doctest/.venv/lib/python3.12/site-packages/boto3/__init__.py", line 16, in <module>
2023-12-08T17:19:53.8310010Z     from boto3.session import Session
2023-12-08T17:19:53.8311400Z   File "/Users/runner/work/sql/sql/doctest/.venv/lib/python3.12/site-packages/boto3/session.py", line 17, in <module>
2023-12-08T17:19:53.8312650Z     import botocore.session
2023-12-08T17:19:53.8313960Z   File "/Users/runner/work/sql/sql/doctest/.venv/lib/python3.12/site-packages/botocore/session.py", line 29, in <module>
2023-12-08T17:19:53.8315270Z     import botocore.configloader
2023-12-08T17:19:53.8316650Z   File "/Users/runner/work/sql/sql/doctest/.venv/lib/python3.12/site-packages/botocore/configloader.py", line 19, in <module>
2023-12-08T17:19:53.8318220Z     from botocore.compat import six
2023-12-08T17:19:53.8319610Z   File "/Users/runner/work/sql/sql/doctest/.venv/lib/python3.12/site-packages/botocore/compat.py", line 33, in <module>
2023-12-08T17:19:53.8321030Z     from botocore.vendored.six.moves import http_client
2023-12-08T17:19:53.8322030Z ModuleNotFoundError: No module named 'botocore.vendored.six.moves'

@dai-chen dai-chen merged commit 91e5b28 into opensearch-project:main Dec 8, 2023
23 of 24 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 8, 2023
* add seder to transportPPLQueryResponse

Signed-off-by: zane-neo <[email protected]>

* add UT for seder

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Fix failure ITs

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 91e5b28)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
penghuo pushed a commit that referenced this pull request Dec 18, 2023
* add seder to transportPPLQueryResponse



* add UT for seder



* format code



* Fix failure ITs



---------


(cherry picked from commit 91e5b28)

Signed-off-by: zane-neo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants