Minor fix in dropping covering index #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vamsimanohar
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
YANG-DB
reviewed
Oct 5, 2023
spark/src/main/java/org/opensearch/sql/spark/flint/FlintIndexType.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Oct 5, 2023
spark/src/main/java/org/opensearch/sql/spark/flint/FlintIndexMetadataReaderImpl.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2226 +/- ##
============================================
- Coverage 96.36% 96.34% -0.02%
+ Complexity 4727 4725 -2
============================================
Files 439 439
Lines 12686 12682 -4
Branches 872 871 -1
============================================
- Hits 12225 12219 -6
- Misses 452 454 +2
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Vamsi Manohar <[email protected]>
penghuo
approved these changes
Oct 5, 2023
dai-chen
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 5, 2023
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 5f76037) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsimanohar
pushed a commit
that referenced
this pull request
Oct 5, 2023
(cherry picked from commit 5f76037) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB
approved these changes
Oct 5, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit 5f76037) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vamsimanohar
pushed a commit
that referenced
this pull request
Oct 6, 2023
(cherry picked from commit 5f76037) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.