Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit long running job only when auto_refresh = false #2208

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

penghuo
Copy link
Collaborator

@penghuo penghuo commented Oct 4, 2023

Description

  • Submit long running job only when auto_refresh = false

Issues Resolved

#2206

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2208 (8154c02) into main (89b011b) will decrease coverage by 0.01%.
The diff coverage is 95.83%.

@@             Coverage Diff              @@
##               main    #2208      +/-   ##
============================================
- Coverage     96.57%   96.57%   -0.01%     
  Complexity     4712     4712              
============================================
  Files           437      437              
  Lines         12552    12574      +22     
  Branches        859      866       +7     
============================================
+ Hits          12122    12143      +21     
  Misses          422      422              
- Partials          8        9       +1     
Flag Coverage Δ
sql-engine 96.57% <95.83%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rch/sql/spark/dispatcher/SparkQueryDispatcher.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/spark/utils/SQLQueryUtils.java 100.00% <100.00%> (ø)
.../spark/asyncquery/model/SparkSubmitParameters.java 98.57% <50.00%> (-1.43%) ⬇️

@penghuo penghuo merged commit 49ea48c into opensearch-project:main Oct 4, 2023
21 of 23 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 4, 2023
* Bug Fix, Submit long running job only when auto_refresh = false

Signed-off-by: Peng Huo <[email protected]>

* update

Signed-off-by: Peng Huo <[email protected]>

---------

Signed-off-by: Peng Huo <[email protected]>
(cherry picked from commit 49ea48c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
YANG-DB pushed a commit that referenced this pull request Oct 4, 2023
* Bug Fix, Submit long running job only when auto_refresh = false



* update



---------


(cherry picked from commit 49ea48c)

Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x v2.11.0 Issues targeting release v2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants