Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Index Implementation #2204

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

vmmusings
Copy link
Member

Description

  • Add capabilities for drop Index Query.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #2204 (41d1301) into main (49ea48c) will decrease coverage by 0.21%.
Report is 1 commits behind head on main.
The diff coverage is 73.58%.

@@             Coverage Diff              @@
##               main    #2204      +/-   ##
============================================
- Coverage     96.57%   96.37%   -0.21%     
- Complexity     4712     4722      +10     
============================================
  Files           437      439       +2     
  Lines         12574    12650      +76     
  Branches        866      869       +3     
============================================
+ Hits          12143    12191      +48     
- Misses          422      450      +28     
  Partials          9        9              
Flag Coverage Δ
sql-engine 96.37% <73.58%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...park/asyncquery/AsyncQueryExecutorServiceImpl.java 100.00% <100.00%> (ø)
.../spark/asyncquery/model/AsyncQueryJobMetadata.java 88.88% <100.00%> (+3.70%) ⬆️
...rch/sql/spark/dispatcher/SparkQueryDispatcher.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/spark/utils/SQLQueryUtils.java 100.00% <100.00%> (ø)
...org/opensearch/sql/spark/flint/FlintIndexType.java 92.85% <92.85%> (ø)
.../sql/spark/flint/FlintIndexMetadataReaderImpl.java 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@vmmusings vmmusings requested a review from GumpacG as a code owner October 4, 2023 20:49
ps48
ps48 previously approved these changes Oct 4, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
@vmmusings vmmusings merged commit 5df6105 into opensearch-project:main Oct 5, 2023
18 of 21 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 5, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 5df6105)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings pushed a commit that referenced this pull request Oct 5, 2023
(cherry picked from commit 5df6105)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants