-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tags to the emr jobs created based on the query. #2150
Merged
vmmusings
merged 1 commit into
opensearch-project:feature/job-apis
from
vmmusings:feature/job-apis
Sep 27, 2023
Merged
Add tags to the emr jobs created based on the query. #2150
vmmusings
merged 1 commit into
opensearch-project:feature/job-apis
from
vmmusings:feature/job-apis
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmmusings
force-pushed
the
feature/job-apis
branch
from
September 26, 2023 00:34
7b11782
to
164fc4d
Compare
Codecov Report
@@ Coverage Diff @@
## feature/job-apis #2150 +/- ##
======================================================
- Coverage 96.59% 96.56% -0.03%
- Complexity 4700 4717 +17
======================================================
Files 433 436 +3
Lines 12405 12535 +130
Branches 844 858 +14
======================================================
+ Hits 11983 12105 +122
- Misses 413 420 +7
- Partials 9 10 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vmmusings
force-pushed
the
feature/job-apis
branch
3 times, most recently
from
September 26, 2023 03:20
542da7d
to
075c9d3
Compare
vmmusings
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
September 26, 2023 03:20
vmmusings
force-pushed
the
feature/job-apis
branch
2 times, most recently
from
September 26, 2023 06:26
03ab1e6
to
cf661a8
Compare
vmmusings
changed the title
Add tags to the emr jobs based on the query.
Add tags to the emr jobs created based on the query.
Sep 26, 2023
vmmusings
force-pushed
the
feature/job-apis
branch
from
September 26, 2023 22:03
cf661a8
to
8a46227
Compare
vmmusings
force-pushed
the
feature/job-apis
branch
from
September 26, 2023 23:25
8a46227
to
f19ede2
Compare
penghuo
reviewed
Sep 27, 2023
spark/src/main/java/org/opensearch/sql/spark/utils/SQLQueryUtils.java
Outdated
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Show resolved
Hide resolved
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Show resolved
Hide resolved
vmmusings
force-pushed
the
feature/job-apis
branch
2 times, most recently
from
September 27, 2023 00:34
6f6d125
to
d281e07
Compare
dai-chen
reviewed
Sep 27, 2023
spark/src/main/java/org/opensearch/sql/spark/dispatcher/SparkQueryDispatcher.java
Show resolved
Hide resolved
dai-chen
reviewed
Sep 27, 2023
Could you add missing Javadoc for new main interface? |
Signed-off-by: Vamsi Manohar <[email protected]>
vmmusings
force-pushed
the
feature/job-apis
branch
from
September 27, 2023 17:34
d281e07
to
cb0ad4e
Compare
Addressed. |
penghuo
approved these changes
Sep 27, 2023
kavithacm
approved these changes
Sep 27, 2023
vmmusings
merged commit Sep 27, 2023
e3c4ee6
into
opensearch-project:feature/job-apis
15 of 19 checks passed
vmmusings
added a commit
that referenced
this pull request
Sep 27, 2023
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <[email protected]> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <[email protected]> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <[email protected]> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <[email protected]> * Add tags to the emr jobs based on the query types (#2150) Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Glue datasource support (#2055) Signed-off-by: Vamsi Manohar <[email protected]> * Initial commit of new job APIs (#2050) Signed-off-by: Vamsi Manohar <[email protected]> * Create Job API (#2070) * Create Job API Signed-off-by: Vamsi Manohar <[email protected]> * Refactor to Async Query API Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> * Cancel Job API (#2126) Signed-off-by: Vamsi Manohar <[email protected]> * Add tags to the emr jobs based on the query types (#2150) Signed-off-by: Vamsi Manohar <[email protected]> --------- Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit ae10857) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings
pushed a commit
that referenced
this pull request
Sep 27, 2023
* Glue datasource support (#2055) * Initial commit of new job APIs (#2050) * Create Job API (#2070) * Create Job API * Refactor to Async Query API --------- * Cancel Job API (#2126) * Add tags to the emr jobs based on the query types (#2150) --------- (cherry picked from commit ae10857) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.