Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use snapshot version for security plugin download #2060

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

vmmusings
Copy link
Member

Description

Build is failing when we run with snapshot=false. This is due to downloading non-snapshot version of security plugin.
As a temporary fix, we will always download snapshot version of security plugin irrespective of security plugin.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #2060 (c379735) into main (9082a46) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2060   +/-   ##
=========================================
  Coverage     97.27%   97.27%           
  Complexity     4623     4623           
=========================================
  Files           410      410           
  Lines         11947    11947           
  Branches        828      828           
=========================================
  Hits          11621    11621           
  Misses          317      317           
  Partials          9        9           
Flag Coverage Δ
sql-engine 97.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📢 Have feedback on the report? Share it here.

@vmmusings vmmusings merged commit e5fa313 into opensearch-project:main Sep 8, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit e5fa313)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2023
Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit e5fa313)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings pushed a commit that referenced this pull request Sep 8, 2023
(cherry picked from commit e5fa313)

Signed-off-by: Vamsi Manohar <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants