-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always use snapshot version for security plugin download #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmmusings
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
September 8, 2023 00:25
Signed-off-by: Vamsi Manohar <[email protected]>
YANG-DB
approved these changes
Sep 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #2060 +/- ##
=========================================
Coverage 97.27% 97.27%
Complexity 4623 4623
=========================================
Files 410 410
Lines 11947 11947
Branches 828 828
=========================================
Hits 11621 11621
Misses 317 317
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. 📢 Have feedback on the report? Share it here. |
seankao-az
approved these changes
Sep 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit e5fa313) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 8, 2023
Signed-off-by: Vamsi Manohar <[email protected]> (cherry picked from commit e5fa313) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vmmusings
pushed a commit
that referenced
this pull request
Sep 8, 2023
vmmusings
pushed a commit
that referenced
this pull request
Sep 8, 2023
(cherry picked from commit e5fa313) Signed-off-by: Vamsi Manohar <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build is failing when we run with snapshot=false. This is due to downloading non-snapshot version of security plugin.
As a temporary fix, we will always download snapshot version of security plugin irrespective of security plugin.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.