-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new setting to ignore pagination where it is unsupported in V2. #1997
Open
Yury-Fridlyand
wants to merge
8
commits into
opensearch-project:main
Choose a base branch
from
Bit-Quill:integ-ignore-pagination-switch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add new setting to ignore pagination where it is unsupported in V2. #1997
Yury-Fridlyand
wants to merge
8
commits into
opensearch-project:main
from
Bit-Quill:integ-ignore-pagination-switch
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…318) * Add new setting to ignore pagination where it is unsupported in V2. Signed-off-by: Yury-Fridlyand <[email protected]> * Use pagination in correctess tests too. Signed-off-by: Yury-Fridlyand <[email protected]> * spotless Signed-off-by: Yury-Fridlyand <[email protected]> * Fix tests. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Yury-Fridlyand
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
August 18, 2023 22:10
Codecov Report
@@ Coverage Diff @@
## main #1997 +/- ##
=========================================
Coverage 97.30% 97.30%
- Complexity 4622 4623 +1
=========================================
Files 407 407
Lines 11934 11946 +12
Branches 827 828 +1
=========================================
+ Hits 11612 11624 +12
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
matthewryanwells
approved these changes
Aug 21, 2023
Signed-off-by: Yury-Fridlyand <[email protected]>
…/opensearch-project-sql into integ-ignore-pagination-switch Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
…tion-switch Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
MitchellGale
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes how pagination requests with unsupported/incompatible [with pagination] queries are handled.
Adds new setting
plugins.query.ignore_unsupported_pagination
:true
by defaulttrue
such requests are performed without paginationfalse
such requests fall back to legacy engineMisc changes:
Please see team review and discussion in Bit-Quill#318.
The new parameter can be configured by
Issues Resolved
Fixes #1765, #78
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.