Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Spotless] Applying Google Code Format for core #5 (#1951) #1996

Merged
merged 4 commits into from
Aug 22, 2023

Conversation

MitchellGale
Copy link
Contributor

Description

Based off #1930, #1931. #1932. #1933 and applies spotless to entire core project. Covers remaining fixes not covered by PR 1-4.

Issues Resolved

#1101

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #1996 (5045c99) into 2.x (d205bd6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##                2.x    #1996   +/-   ##
=========================================
  Coverage     97.51%   97.51%           
  Complexity     4658     4658           
=========================================
  Files           408      408           
  Lines         11930    11931    +1     
  Branches        831      831           
=========================================
+ Hits          11633    11634    +1     
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...g/opensearch/sql/data/model/AbstractExprValue.java 100.00% <ø> (ø)
...a/org/opensearch/sql/data/model/ExprTimeValue.java 100.00% <100.00%> (ø)
...org/opensearch/sql/data/type/WideningTypeRule.java 100.00% <100.00%> (ø)

@MitchellGale MitchellGale marked this pull request as draft August 18, 2023 22:44
@MitchellGale MitchellGale marked this pull request as ready for review August 22, 2023 18:26
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
acarbonetto
acarbonetto previously approved these changes Aug 22, 2023
Signed-off-by: Mitchell Gale <[email protected]>
@Yury-Fridlyand Yury-Fridlyand merged commit a85a142 into opensearch-project:2.x Aug 22, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the backport2.x-1951 branch August 22, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants