-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spotless] Applying Google Code Format for legacy directory (pt 2/4) #20 #1989
[Spotless] Applying Google Code Format for legacy directory (pt 2/4) #20 #1989
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1989 +/- ##
=========================================
Coverage 97.30% 97.30%
Complexity 4621 4621
=========================================
Files 407 407
Lines 11933 11933
Branches 826 826
=========================================
Hits 11611 11611
Misses 315 315
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Mitchell Gale <[email protected]>
56b4801
to
ee426c9
Compare
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Compilation fails |
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
...ch/src/main/java/org/opensearch/sql/opensearch/storage/script/filter/lucene/LuceneQuery.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mitchell Gale <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/sql/backport-2.x
# Create a new branch
git switch --create backport/backport-1989-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 220150969209bc8eefbac44fa0fc2f3ebc461687
# Push it to GitHub
git push --set-upstream origin backport/backport-1989-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.x Then, create a pull request where the |
(opensearch-project#1989) * Spotless apply for legacy pt 2 Signed-off-by: Mitchell Gale <[email protected]> * spotless apply Signed-off-by: Mitchell Gale <[email protected]> * Spotless apply for legacy pt 2 Signed-off-by: Mitchell Gale <[email protected]> * spotless apply Signed-off-by: Mitchell Gale <[email protected]> * updated type Signed-off-by: Mitchell Gale <[email protected]> * removed spotless Signed-off-by: Mitchell Gale <[email protected]> * add spotless Signed-off-by: Mitchell Gale <[email protected]> * removed extra test Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
ported by #2016, removing backport failed label |
Thank you |
Description
Applies spotless for part of legacy directory in project. Sets checkstyle to not fail on failure for legacy directory.
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.