Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spotless] Remove unused imports #1927

Merged

Conversation

MitchellGale
Copy link
Contributor

Description

Removes unused imports through spotless.

Note: This PR branch is based off #1926, so changes from 1926 will also show up here until 1926 is merged.

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

MitchellGale and others added 10 commits August 2, 2023 18:49
Signed-off-by: Mitchell Gale <[email protected]>

Remove commented out spotless changes.

Signed-off-by: Mitchell Gale <[email protected]>

Adding Spotless to DEVELOPER_GUIDE.rst

Signed-off-by: Mitchell Gale <[email protected]>

Added Google Java format to spotless.

Signed-off-by: Mitchell Gale <[email protected]>

Update DEVELOPER_GUIDE.rst

Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #1927 (560681d) into main (d2de909) will not change coverage.
The diff coverage is n/a.

❗ Current head 560681d differs from pull request most recent head df888d6. Consider uploading reports for the commit df888d6 to get more accurate results

@@            Coverage Diff            @@
##               main    #1927   +/-   ##
=========================================
  Coverage     97.42%   97.42%           
  Complexity     4647     4647           
=========================================
  Files           408      408           
  Lines         11526    11526           
  Branches        839      839           
=========================================
  Hits          11229    11229           
  Misses          290      290           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <ø> (ø)
...alysis/DataSourceSchemaIdentifierNameResolver.java 100.00% <ø> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <ø> (ø)
...ensearch/sql/analysis/NamedExpressionAnalyzer.java 100.00% <ø> (ø)
...ecutor/streaming/MicroBatchStreamingExecution.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <ø> (ø)
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <ø> (ø)
...search/sql/planner/logical/LogicalFetchCursor.java 100.00% <ø> (ø)
...arch/sql/planner/physical/AggregationOperator.java 100.00% <ø> (ø)
.../sql/planner/physical/PhysicalPlanNodeVisitor.java 100.00% <ø> (ø)
... and 13 more

Signed-off-by: Mitchell Gale <[email protected]>
@GumpacG GumpacG merged commit 605f3df into opensearch-project:main Aug 3, 2023
@MitchellGale MitchellGale mentioned this pull request Aug 3, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants