Pagination Phase 2: Support ORDER BY clauses and queries without FROM.

[Yury-Fridlyand]

Pagination in V2: Phase 2. See Phase 1 in #1497.

Doc: https://github.com/Bit-Quill/opensearch-project-sql/blob/61767f2b200b2a7f8c8b2df32de209b3c30caa61/docs/dev/Pagination-v2.md

This PR depends on #1500.

curl -XPOST http://localhost:9200/_plugins/_sql -H 'Content-Type: application/json' -d '{"query": "select * from calcs order by int0, num1;", "fetch_size": 3 }'

You can use attached script for testing as well. Command line: ./cursor_test.sh <table> <page size>. Requires jq. Rename the script before use.
cursor_test.sh.txt

Description

Add support for more complex queries in paged requests.
Supported things:

• GROUP BY clause
• queries without FROM clause

Unsupported things:

• expressions in ORDER BY - [FEATURE] Implement pushDownSort for ORDER BY clause with an expression #1471

Issues Resolved

Support of ORDER BY clause and support queries without FROM clause.

Check List

• New functionality includes testing.
  • All tests pass, including unit test, integration test and doctest
• New functionality has been documented.
  • New functionality has javadoc added
  • New functionality has user manual doc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #1599 (5b75395) into main (29f99aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1599   +/-   ##
=========================================
  Coverage     97.31%   97.31%           
- Complexity     4372     4375    +3     
=========================================
  Files           385      385           
  Lines         10847    10850    +3     
  Branches        763      765    +2     
=========================================
+ Hits          10556    10559    +3     
  Misses          284      284           
  Partials          7        7           

Flag	Coverage Δ
sql-engine	97.31% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ch/sql/executor/pagination/CanPaginateVisitor.java	100.00% <100.00%> (ø)
...org/opensearch/sql/planner/DefaultImplementor.java	100.00% <100.00%> (ø)

[anirudha]

Thanks!

[acarbonetto]

why?

[Yury-Fridlyand]

I had a test which uses (overrides) it, but it become irrelevant after merging with #1500.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1599-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 94d5479522ba5ae83645c4169d6cc44a38b720de
# Push it to GitHub
git push --set-upstream origin backport/backport-1599-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1599-to-2.x.

[Yury-Fridlyand]

Will restart backport after merging #1741