Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep up with refactoring in OpenSearch. #1588

Conversation

MaxKsyunz
Copy link
Collaborator

Addressing changes by opensearch-project/OpenSearch#7309

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov-commenter
Copy link

Codecov Report

Merging #1588 (9ee4e3c) into main (b90065f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1588   +/-   ##
=========================================
  Coverage     97.16%   97.16%           
  Complexity     4116     4116           
=========================================
  Files           371      371           
  Lines         10365    10366    +1     
  Branches        704      704           
=========================================
+ Hits          10071    10072    +1     
  Misses          287      287           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/sql/opensearch/client/OpenSearchNodeClient.java 100.00% <100.00%> (ø)
...ch/sql/opensearch/client/OpenSearchRestClient.java 100.00% <100.00%> (ø)

Signed-off-by: MaxKsyunz <[email protected]>
@MaxKsyunz
Copy link
Collaborator Author

SQL Java CI is failing on BWC test suite. This was the case before this PR and looks to be a problem in core -- last time BWC tests pass their was almost a week ago.

@Yury-Fridlyand Yury-Fridlyand merged commit 3fc11a4 into opensearch-project:main Apr 27, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the chore/refactor/opensearch/#7309 branch April 27, 2023 18:44
acarbonetto pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Apr 28, 2023
* Keep up with refactoring in OpenSearch.

Signed-off-by: MaxKsyunz <[email protected]>

* Updating code formatting.

Signed-off-by: MaxKsyunz <[email protected]>

---------

Signed-off-by: MaxKsyunz <[email protected]>
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jun 12, 2023
* Keep up with refactoring in OpenSearch.

Signed-off-by: MaxKsyunz <[email protected]>

* Updating code formatting.

Signed-off-by: MaxKsyunz <[email protected]>

---------

Signed-off-by: MaxKsyunz <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 30, 2023
* Keep up with refactoring in OpenSearch.

Signed-off-by: MaxKsyunz <[email protected]>

* Updating code formatting.

Signed-off-by: MaxKsyunz <[email protected]>

---------

Signed-off-by: MaxKsyunz <[email protected]>
(cherry picked from commit 3fc11a4)
MaxKsyunz pushed a commit that referenced this pull request Jul 5, 2023
* Keep up with refactoring in OpenSearch.

Signed-off-by: MaxKsyunz <[email protected]>

* Updating code formatting.

Signed-off-by: MaxKsyunz <[email protected]>

---------

Signed-off-by: MaxKsyunz <[email protected]>
(cherry picked from commit 3fc11a4)
Signed-off-by: MaxKsyunz <[email protected]>
Yury-Fridlyand pushed a commit that referenced this pull request Jul 5, 2023
* Keep up with refactoring in OpenSearch.



* Updating code formatting.



---------


(cherry picked from commit 3fc11a4)

Signed-off-by: MaxKsyunz <[email protected]>
Co-authored-by: Max Ksyunz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants