Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hash join benchmark doc #1568

Merged

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Apr 20, 2023

Description

Publish hash join benchmark test report for community visibility. The test was performed for new Block Hash Join before SQL plugin launched.

Reference:

  1. Index: https://github.com/dai-chen/sql-1/blob/add-hash-join-benchmark-doc/docs/dev/index.md#other-documents
  2. Doc: https://github.com/dai-chen/sql-1/blob/add-hash-join-benchmark-doc/docs/dev/testing-hash-join-benchmark.md

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dai-chen dai-chen self-assigned this Apr 20, 2023
@dai-chen dai-chen added documentation Improvements or additions to documentation SQL labels Apr 20, 2023
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2023

Codecov Report

Merging #1568 (e0b8efe) into main (bc29a8a) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1568   +/-   ##
=========================================
  Coverage     97.16%   97.16%           
  Complexity     4117     4117           
=========================================
  Files           371      371           
  Lines         10366    10366           
  Branches        704      704           
=========================================
  Hits          10072    10072           
  Misses          287      287           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

YANG-DB
YANG-DB previously approved these changes Apr 27, 2023
Yury-Fridlyand
Yury-Fridlyand previously approved these changes Apr 28, 2023
docs/dev/testing-hash-join-benchmark.md Show resolved Hide resolved
Signed-off-by: Chen Dai <[email protected]>
@dai-chen dai-chen dismissed stale reviews from Yury-Fridlyand and YANG-DB via b6f3f1b May 1, 2023 22:10
@dai-chen dai-chen requested review from YANG-DB and Yury-Fridlyand May 1, 2023 22:11
@dai-chen dai-chen merged commit a973c0e into opensearch-project:main May 9, 2023
@dai-chen dai-chen deleted the add-hash-join-benchmark-doc branch May 9, 2023 22:01
MitchellGale pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Jun 12, 2023
* Add hash join benchmark doc

Signed-off-by: Chen Dai <[email protected]>

* Fix graph link

Signed-off-by: Chen Dai <[email protected]>

* Reformat with new lines

Signed-off-by: Chen Dai <[email protected]>

* Rename doc title

Signed-off-by: Chen Dai <[email protected]>

* Add note for OOM

Signed-off-by: Chen Dai <[email protected]>

---------

Signed-off-by: Chen Dai <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation SQL
Projects
Status: Planned work items
Development

Successfully merging this pull request may close these issues.

5 participants