Ensure Nested Function Falls Back to Legacy Engine Where Not Supported #1549
Conversation
forestmvey
requested review from
anirudha,
penghuo,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Yury-Fridlyand and
MaxKsyunz
as code owners
| rows("a"), | ||
| rows("a")); | ||
| } | ||
|
|
There was a problem hiding this comment.
You can run query with nested in where and validate server logs to ensure that it is executed in V1.
…d ORDER BY clauses don't fallback to legacy engine. Signed-off-by: forestmvey <[email protected]>
forestmvey
force-pushed
the
integ-nested-fallback
branch
from
e574dd2 to
43b70c4
Compare
|
Could you update 2.7 release notes too? Thanks! |
Sure I will make another PR for the release notes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
=========================================
Coverage 97.18% 97.18%
- Complexity 4100 4106 +6
=========================================
Files 371 371
Lines 10448 10462 +14
Branches 703 706 +3
=========================================
+ Hits 10154 10168 +14
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Legacy tests only run against the the V1 engine when they use the function |
|
@forestmvey I see. Please get others approved and merge it. We need to merge this and release notes PR today. Thanks! |
…d ORDER BY clauses don't fallback to legacy engine. (#1549) Signed-off-by: forestmvey <[email protected]> (cherry picked from commit 59ef998)
…d ORDER BY clauses don't fallback to legacy engine. (#1549) Signed-off-by: forestmvey <[email protected]> (cherry picked from commit 59ef998)
…d ORDER BY clauses don't fallback to legacy engine. (#1549) (#1555) Signed-off-by: forestmvey <[email protected]> (cherry picked from commit 59ef998) Co-authored-by: Forest Vey <[email protected]>
…d ORDER BY clauses don't fallback to legacy engine. (#1549) (#1554) Signed-off-by: forestmvey <[email protected]> (cherry picked from commit 59ef998) Co-authored-by: Forest Vey <[email protected]>
…d ORDER BY clauses don't fallback to legacy engine. (opensearch-project#1549) Signed-off-by: forestmvey <[email protected]>
Description
Fallback to legacy engine when the nested function is used in the
WHERE,GROUP BY,ORDER BY, andHAVINGclauses. Support has not been added to the V2 engine for the nested query in these clauses.Issues Resolved
1548
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.