Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasources Integ Test Fix #1541

Merged

Conversation

vamsimanohar
Copy link
Member

@vamsimanohar vamsimanohar commented Apr 18, 2023

Description

  • with the current state, integ-state fails when cluster restricts actions on system index .ql-datasources.
  • In order to avoid this, moved populating datasources using APIs instead of loading data directly in .ql-datasources.

Issues Resolved

#1538

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vamsimanohar vamsimanohar linked an issue Apr 18, 2023 that may be closed by this pull request
Signed-off-by: vamsi-amazon <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1541 (ea8042f) into main (fd1d7d8) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1541   +/-   ##
=========================================
  Coverage     97.18%   97.18%           
  Complexity     4100     4100           
=========================================
  Files           371      371           
  Lines         10448    10448           
  Branches        703      703           
=========================================
  Hits          10154    10154           
  Misses          287      287           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vamsimanohar vamsimanohar merged commit 4e9ca01 into opensearch-project:main Apr 18, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2023
(cherry picked from commit 4e9ca01)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 18, 2023
(cherry picked from commit 4e9ca01)
vamsimanohar added a commit that referenced this pull request Apr 18, 2023
(cherry picked from commit 4e9ca01)

Co-authored-by: Vamsi Manohar <[email protected]>
vamsimanohar added a commit that referenced this pull request Apr 18, 2023
(cherry picked from commit 4e9ca01)

Co-authored-by: Vamsi Manohar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.7 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AUTOCUT] Integration Test failed for sql: 2.7.0 tar distribution
4 participants