Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Add publish snapshots to maven via GHA #1496

Merged
merged 1 commit into from
Apr 5, 2023
Merged

[Backport 2.x] Add publish snapshots to maven via GHA #1496

merged 1 commit into from
Apr 5, 2023

Conversation

rupal-bq
Copy link
Contributor

@rupal-bq rupal-bq commented Apr 5, 2023

Description

Backporting #1359 to 2.x

Local testing output

maharup@b0f1d879dff7 plugin % find snapshots | sort 
snapshots
snapshots/org
snapshots/org/opensearch
snapshots/org/opensearch/plugin
snapshots/org/opensearch/plugin/opensearch-sql-plugin
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/maven-metadata.xml
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/maven-metadata.xml.md5
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/maven-metadata.xml.sha1
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/maven-metadata.xml.sha256
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/maven-metadata.xml.sha512
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.pom
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.pom.md5
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.pom.sha1
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.pom.sha256
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.pom.sha512
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.zip
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.zip.md5
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.zip.sha1
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.zip.sha256
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.185902-1.zip.sha512
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.pom
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.pom.md5
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.pom.sha1
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.pom.sha256
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.pom.sha512
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.zip
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.zip.md5
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.zip.sha1
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.zip.sha256
snapshots/org/opensearch/plugin/opensearch-sql-plugin/2.7.0.0-SNAPSHOT/opensearch-sql-plugin-2.7.0.0-20230405.190121-2.zip.sha512
snapshots/org/opensearch/plugin/opensearch-sql-plugin/maven-metadata.xml
snapshots/org/opensearch/plugin/opensearch-sql-plugin/maven-metadata.xml.md5
snapshots/org/opensearch/plugin/opensearch-sql-plugin/maven-metadata.xml.sha1
snapshots/org/opensearch/plugin/opensearch-sql-plugin/maven-metadata.xml.sha256
snapshots/org/opensearch/plugin/opensearch-sql-plugin/maven-metadata.xml.sha512

Issues Resolved

#1358

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rupal-bq rupal-bq requested a review from a team as a code owner April 5, 2023 19:12
@dai-chen dai-chen added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Apr 5, 2023
Yury-Fridlyand
Yury-Fridlyand approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably you need to backport to 2.7 as well

@rupal-bq rupal-bq merged commit 17b1105 into opensearch-project:2.x Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@penghuo penghuo penghuo approved these changes

Assignees
No one assigned
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rupal-bq @penghuo @YANG-DB @Yury-Fridlyand @dai-chen