Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SINH function to V2 engine #1434

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

matthewryanwells
Copy link
Contributor

Description

Updated SINH function to V2 engine, added documentation, unit/IT tests

Issues Resolved

#1190

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Updated SINH function to V2 engine, added documentation, unit/IT tests

Signed-off-by: Matthew Wells <[email protected]>
@matthewryanwells matthewryanwells requested a review from a team as a code owner March 13, 2023 22:09
@dai-chen dai-chen merged commit c9f96fb into opensearch-project:main Mar 15, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 15, 2023
* Updated SINH function to V2 engine, added documentation, unit/IT tests

Signed-off-by: Matthew Wells <[email protected]>
(cherry picked from commit c9f96fb)
Yury-Fridlyand pushed a commit that referenced this pull request Mar 15, 2023
* Updated SINH function to V2 engine, added documentation, unit/IT tests

Signed-off-by: Matthew Wells <[email protected]>
(cherry picked from commit c9f96fb)

Co-authored-by: Matthew Wells <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants