Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport main] Refactor AWSSigV4 auth to support different AWSCredentialProviders #1396

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 8583fd1 from #1389

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner March 3, 2023 18:17
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Merging #1396 (e08fc51) into main (cd95bc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##               main    #1396   +/-   ##
=========================================
  Coverage     98.38%   98.38%           
- Complexity     3693     3694    +1     
=========================================
  Files           343      343           
  Lines          9107     9113    +6     
  Branches        585      586    +1     
=========================================
+ Hits           8960     8966    +6     
  Misses          142      142           
  Partials          5        5           
Flag Coverage Δ
sql-engine 98.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...etheus/authinterceptors/AwsSigningInterceptor.java 100.00% <100.00%> (ø)
...l/prometheus/storage/PrometheusStorageFactory.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yury-Fridlyand
Copy link
Collaborator

@opensearch-ci-bot rebase
Does it smart enough?

…1389)

* Refactor AWSSigV4 auth to support different AWSCredentialProviders

Signed-off-by: Vamsi Manohar <[email protected]>

* Added unit tests for sts assume role credentials provider

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 8583fd1)
@vmmusings vmmusings force-pushed the backport/backport-1389-to-main branch from 26ba118 to e08fc51 Compare March 7, 2023 21:26
@vmmusings vmmusings merged commit ecea812 into main Mar 7, 2023
@github-actions github-actions bot deleted the backport/backport-1389-to-main branch March 7, 2023 22:46
matthewryanwells pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Mar 10, 2023
…pensearch-project#1389) (opensearch-project#1396)

* Refactor AWSSigV4 auth to support different AWSCredentialProviders

Signed-off-by: Vamsi Manohar <[email protected]>

* Added unit tests for sts assume role credentials provider

Signed-off-by: Vamsi Manohar <[email protected]>

---------

Signed-off-by: Vamsi Manohar <[email protected]>
(cherry picked from commit 8583fd1)

Co-authored-by: vamsi-amazon <[email protected]>
Signed-off-by: Matthew Wells <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants