Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo fix and minor improvement in maven-publish GHA workflow. #1387

Conversation

Yury-Fridlyand
Copy link
Collaborator

Description

Typo fix in maven-publish GHA workflow - branch list has to be a comma-separate list or list of entries.
I also updated aws-actions/configure-aws-credentials used to avoid coming deprecation and disabled this workflow to run on forks.

Issues Resolved

#1358, #1359

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner March 1, 2023 01:17
@Yury-Fridlyand Yury-Fridlyand merged commit 259b001 into opensearch-project:main Mar 3, 2023
@Yury-Fridlyand Yury-Fridlyand deleted the fix-publish-to-maven-workflow branch March 3, 2023 21:53
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1387-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 259b001f1c66dd0fc9b82547496516db1155ca11
# Push it to GitHub
git push --set-upstream origin backport/backport-1387-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1387-to-2.x.

matthewryanwells pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Mar 7, 2023
acarbonetto pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Mar 7, 2023
matthewryanwells pushed a commit to Bit-Quill/opensearch-project-sql that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants