-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve table function based on StorageEngine provided function resolver #1354
Conversation
Signed-off-by: Peng Huo <[email protected]>
@@ -8,5 +8,5 @@ | |||
public enum DataSourceType { | |||
PROMETHEUS, | |||
OPENSEARCH, | |||
FILESYSTEM | |||
JDBC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FILESYSTEM supported has been removed in #1284.
@@ -62,7 +62,7 @@ dependencies { | |||
test { | |||
useJUnitPlatform() | |||
testLogging { | |||
events "passed", "skipped", "failed" | |||
events "skipped", "failed" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ignore log PASSED test cases.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1354 +/- ##
============================================
- Coverage 98.38% 98.38% -0.01%
+ Complexity 3698 3695 -3
============================================
Files 343 343
Lines 9121 9113 -8
Branches 586 582 -4
============================================
- Hits 8974 8966 -8
Misses 142 142
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
To reviewer: Ignore failed bwc test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
Signed-off-by: Peng Huo <[email protected]>
Signed-off-by: Peng Huo <[email protected]>
…#1354) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit bcfda37)
…#1354) (#1424) Signed-off-by: Peng Huo <[email protected]> (cherry picked from commit bcfda37) Co-authored-by: Peng Huo <[email protected]>
Description
Issues Resolved
#1331
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.