Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.4] Fixed error with single timestamp filter query on prometheus datasource #1247

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport ee949cc from #1244

Signed-off-by: vamsi-amazon <[email protected]>

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit ee949cc)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 7, 2023 02:03
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2023

Codecov Report

Merging #1247 (6fc265a) into 2.4 (c6756ec) will decrease coverage by 2.58%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.4    #1247      +/-   ##
============================================
- Coverage     98.26%   95.69%   -2.58%     
- Complexity     3332     3333       +1     
============================================
  Files           324      334      +10     
  Lines          8413     9072     +659     
  Branches        553      673     +120     
============================================
+ Hits           8267     8681     +414     
- Misses          142      334     +192     
- Partials          4       57      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rage/querybuilder/SeriesSelectionQueryBuilder.java 100.00% <100.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
workbench/public/components/Main/main.tsx 53.00% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
workbench/public/components/PPLPage/PPLPage.tsx 56.52% <0.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen added the bug Something isn't working label Jan 9, 2023
YANG-DB
YANG-DB previously approved these changes Jan 19, 2023
dai-chen
dai-chen previously approved these changes Jan 20, 2023
@dai-chen
Copy link
Collaborator

Rerunning failed workflow.

Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are compilation errors. Perhaps manual merge required.

@dai-chen
Copy link
Collaborator

@vamsi-amazon Could you have a look if we need to close this and merge manually?

@vmmusings
Copy link
Member

@dai-chen will address this by Friday EOD.

@vmmusings vmmusings dismissed stale reviews from dai-chen and YANG-DB via 6fc265a January 31, 2023 04:19
@vmmusings vmmusings merged commit c3625b3 into 2.4 Jan 31, 2023
@github-actions github-actions bot deleted the backport/backport-1244-to-2.4 branch January 31, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants