Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Suppress CI failures not related to testing/building #1220

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[Backport 2.x] Suppress CI failures not related to testing/building #1220

merged 1 commit into from
Jan 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 683d92f from #1180

@Yury-Fridlyand @github-actions
Suppress report uploading failure in CI. (#1180)
3e02fad 
Signed-off-by: Yury-Fridlyand <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>
(cherry picked from commit 683d92f)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner January 4, 2023 00:47
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2023 •
edited
Loading

Codecov Report

Merging #1220 (3e02fad) into 2.x (67f7f98) will decrease coverage by 2.48%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1220      +/-   ##
============================================
- Coverage     98.32%   95.84%   -2.49%     
  Complexity     3555     3555              
============================================
  Files           346      356      +10     
  Lines          8768     9426     +658     
  Branches        554      673     +119     
============================================
+ Hits           8621     9034     +413     
- Misses          142      334     +192     
- Partials          5       58      +53
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ch/public/components/QueryResults/QueryResults.tsx 61.60% <0.00%> (ø)
workbench/public/utils/PanelWrapper.tsx 100.00% <0.00%> (ø)
workbench/public/components/SQLPage/SQLPage.tsx 100.00% <0.00%> (ø)
workbench/public/components/Header/Header.tsx 100.00% <0.00%> (ø)
...ublic/components/QueryResults/QueryResultsBody.tsx 68.32% <0.00%> (ø)
workbench/public/components/Main/main.tsx 53.00% <0.00%> (ø)
workbench/public/components/PPLPage/PPLPage.tsx 56.52% <0.00%> (ø)
workbench/public/application.tsx 0.00% <0.00%> (ø)
workbench/public/components/app.tsx 0.00% <0.00%> (ø)
...h/public/components/QueryLanguageSwitch/Switch.tsx 85.71% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Yury-Fridlyand Yury-Fridlyand added the infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. label Jan 4, 2023
@Yury-Fridlyand
Copy link
Collaborator

Yury-Fridlyand commented Jan 4, 2023 •
edited
Loading

Ahh, I fixed Upload test reports step, but CI failed on Upload Artifacts 🤦
https://github.com/opensearch-project/sql/actions/runs/3834195557/jobs/6526362787

@penghuo penghuo merged commit de79815 into 2.x Jan 4, 2023
@github-actions github-actions bot deleted the backport/backport-1180-to-2.x branch January 4, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yury-Fridlyand Yury-Fridlyand Yury-Fridlyand approved these changes

@penghuo penghuo penghuo approved these changes

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

Assignees
No one assigned
Labels
infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codecov-commenter @Yury-Fridlyand @penghuo