Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.3] Bump jackson to 2.14.0 #1149

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

closes #1148

Issues Resolved

#1148

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 requested a review from a team as a code owner December 7, 2022 19:54
@joshuali925
Copy link
Member Author

CI will fail until opensearch snapshot is updated

@qreshi
Copy link
Contributor

qreshi commented Dec 7, 2022

@joshuali925 Pardon my ignorance, I just had a question based on what you mentioned above. If the SQL Java CI uses a snapshot to run the test, doesn't that mean you won't catch failures being introduced by the PRs that the CI is running for? For example, this build error should have been caught in the version bump PR but I see the CIs were passing there. Just wanted to confirm if this is a chicken-egg issue for catching build failures.

@joshuali925
Copy link
Member Author

@qreshi i believe #1148 is using mavenlocal

@joshuali925 joshuali925 merged commit 0e43de4 into opensearch-project:2.3 Dec 7, 2022
@dai-chen dai-chen added the dependencies Pull requests that update a dependency file label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants