Update junit version to 5.6.2 #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rupal Mahajan <[email protected]>
Yury-Fridlyand
approved these changes
Nov 16, 2022
derek-ho
reviewed
Nov 16, 2022
| @@ -42,6 +42,7 @@ test { | |||
| configurations.all { | |||
| resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib:1.6.0" | |||
| resolutionStrategy.force "org.jetbrains.kotlin:kotlin-stdlib-common:1.6.0" | |||
| resolutionStrategy.force "org.junit.jupiter:junit-jupiter:5.6.2" | |||
There was a problem hiding this comment.
Is it safe to use alpha releases? Curious as to whether it is better to force it here or to upgrade mockwebserver to a version that doesn't bring in the older version
https://mvnrepository.com/artifact/com.squareup.okhttp3/mockwebserver
There was a problem hiding this comment.
It is better to upgrade but 4.10 has the same junit CVE and 5+ are alpha candidates.
penghuo
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rupal Mahajan [email protected]
Description
Added junit to resolutions.
junit 4.13 was identified at
prometheus/build.gradle > testCompileClasspath > [email protected] > [email protected]Issues Resolved
CVE-2020-15250
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.