-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Some queries failing with code 500: all shards failed | Failed to compile inline script #273
Comments
Many of the expressions are translated to DSL before executing, this results in a lot of compiling work, so when many requests hit the engine in parallel, the engine might run out of the resources and give out compiling error. We should optimize the expression calculation to fix this issue, but short termly it is recommended to scale your instance up or out. Optionally, we also recommend you change the queries to our preferred semantic, for example, use implicit/explicit cast from string literal to timestamp (e.g. cast('2021-11-09 00:00:00' as timestamp) or directly '2021-11-09 00:00:00') instead of using functions like timestamp('2021-11-09 00:00:00') to do the data converting. |
I have conducted some research into the performance of the functions you mentioned and data type inputs for those functions to see how quickly they run to see if that is an issue that could cause the test failures. The results are in operations per second meaning that the higher the number is the faster it runs, below I have laid out my findings:
The overall efficiency of almost all functions have gone down in the newer version with the exception of giving So although it is faster most of the time to case as timestamp it doesn't appear to be a big enough of a performance hit to be causing test to fail |
* Support user-defined and incomplete date formats (#273) * Check custom formats for characters Signed-off-by: Guian Gumpac <[email protected]> * Removed duplicated code Signed-off-by: Guian Gumpac <[email protected]> * Reworked checking for exprcoretype Signed-off-by: Guian Gumpac <[email protected]> * Changed check for time Signed-off-by: Guian Gumpac <[email protected]> * Rework processing custom and incomplete formats and add tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Values of incomplete and incorrect formats to be returned as `TIMESTAMP` instead of `STRING`. Signed-off-by: Yury-Fridlyand <[email protected]> * Complete fix and update tests. Signed-off-by: Yury-Fridlyand <[email protected]> * More fixes for god of fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Refactoring. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Guian Gumpac <[email protected]>
* Support user-defined and incomplete date formats (#273) * Check custom formats for characters Signed-off-by: Guian Gumpac <[email protected]> * Removed duplicated code Signed-off-by: Guian Gumpac <[email protected]> * Reworked checking for exprcoretype Signed-off-by: Guian Gumpac <[email protected]> * Changed check for time Signed-off-by: Guian Gumpac <[email protected]> * Rework processing custom and incomplete formats and add tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Values of incomplete and incorrect formats to be returned as `TIMESTAMP` instead of `STRING`. Signed-off-by: Yury-Fridlyand <[email protected]> * Complete fix and update tests. Signed-off-by: Yury-Fridlyand <[email protected]> * More fixes for god of fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Refactoring. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Guian Gumpac <[email protected]> (cherry picked from commit a60b222)
* Support user-defined and incomplete date formats (#273) * Check custom formats for characters Signed-off-by: Guian Gumpac <[email protected]> * Removed duplicated code Signed-off-by: Guian Gumpac <[email protected]> * Reworked checking for exprcoretype Signed-off-by: Guian Gumpac <[email protected]> * Changed check for time Signed-off-by: Guian Gumpac <[email protected]> * Rework processing custom and incomplete formats and add tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Values of incomplete and incorrect formats to be returned as `TIMESTAMP` instead of `STRING`. Signed-off-by: Yury-Fridlyand <[email protected]> * Complete fix and update tests. Signed-off-by: Yury-Fridlyand <[email protected]> * More fixes for god of fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Refactoring. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Guian Gumpac <[email protected]> (cherry picked from commit a60b222) Co-authored-by: Yury-Fridlyand <[email protected]>
* Support user-defined and incomplete date formats (#273) * Check custom formats for characters Signed-off-by: Guian Gumpac <[email protected]> * Removed duplicated code Signed-off-by: Guian Gumpac <[email protected]> * Reworked checking for exprcoretype Signed-off-by: Guian Gumpac <[email protected]> * Changed check for time Signed-off-by: Guian Gumpac <[email protected]> * Rework processing custom and incomplete formats and add tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Values of incomplete and incorrect formats to be returned as `TIMESTAMP` instead of `STRING`. Signed-off-by: Yury-Fridlyand <[email protected]> * Complete fix and update tests. Signed-off-by: Yury-Fridlyand <[email protected]> * More fixes for god of fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Refactoring. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Guian Gumpac <[email protected]> (cherry picked from commit a60b222)
* Support user-defined and incomplete date formats (#273) * Check custom formats for characters Signed-off-by: Guian Gumpac <[email protected]> * Removed duplicated code Signed-off-by: Guian Gumpac <[email protected]> * Reworked checking for exprcoretype Signed-off-by: Guian Gumpac <[email protected]> * Changed check for time Signed-off-by: Guian Gumpac <[email protected]> * Rework processing custom and incomplete formats and add tests. Signed-off-by: Yury-Fridlyand <[email protected]> * Values of incomplete and incorrect formats to be returned as `TIMESTAMP` instead of `STRING`. Signed-off-by: Yury-Fridlyand <[email protected]> * Complete fix and update tests. Signed-off-by: Yury-Fridlyand <[email protected]> * More fixes for god of fixes. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> * Refactoring. Signed-off-by: Yury-Fridlyand <[email protected]> --------- Signed-off-by: Guian Gumpac <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Co-authored-by: Guian Gumpac <[email protected]> (cherry picked from commit a60b222) Co-authored-by: Yury-Fridlyand <[email protected]>
Describe the bug
I started TDVT test suite using JDBC driver 5 times and got 5 different results:
To Reproduce
Steps to reproduce the behavior:
C:\Users\%username%\Documents\My Tableau Repository\Connectors
python -m tdvt.tdvt run OpenSearch
few timesExpected result
Tests would produce the same result all times
Actual result
214 tests failed at the 5th run with the following error:
Additional context
The connector forces driver to produce log at
%temp%\TableauTemp\jdbc-driver-log.txt
See logs attached:
test-5.zip
test-1.zip
test-2.zip
test-3.zip
test-4.zip
tests-3-4-5-result-compare.csv
test-5-jdbc-driver-log.txt
test-5-part-of-server-log.txt
The text was updated successfully, but these errors were encountered: